diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2021-03-09 09:05:39 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-03-24 23:30:54 +0000 |
| commit | 774ff171f1ff84e7f3daa2f367b9563e00656488 (patch) | |
| tree | fc8007077bd004eb9ef6e48b9197d020d472ab33 /util | |
| parent | b8103dc44bd202c762a8829a58b9091060ebf64d (diff) | |
| download | chrome-ec-774ff171f1ff84e7f3daa2f367b9563e00656488.tar.gz | |
ctn730: Print firmware version
This patch makes ctn730 driver print the firmware version.
EC_CMD_PCHG is updated to version 1 and returns firmware version
of a charger chip. Version 0 of EC_CMD_PCHG is deprecated.
BUG=b:182600604, b:173235954, b:183151376
BRANCH=Trogdor
TEST=Verify firmware version is printed on EC console.
TEST=ectool pchg 0 (for version 1)
TEST=cat /sys/class/power_supply/PCHG0/* (for version 0)
"ERR kernel: [ 33.394847] cros-ec-pchg cros-ec-pchg.13.auto:
Unable to get port.0 status (err:-524)"
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: Ib7bb9a7225fe914bc6c8d600d0f4766dbf75ace8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2757098
Diffstat (limited to 'util')
| -rw-r--r-- | util/ectool.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/util/ectool.c b/util/ectool.c index 459a7158b5..091362c234 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -9388,7 +9388,7 @@ int cmd_pchg(int argc, char *argv[]) struct ec_response_pchg *r = ec_inbuf; p->port = port; - rv = ec_command(EC_CMD_PCHG, 0, ec_outbuf, sizeof(*p), + rv = ec_command(EC_CMD_PCHG, 1, ec_outbuf, sizeof(*p), ec_inbuf, ec_max_insize); if (rv < 0) { fprintf(stderr, "Error code: %d\n", rv); @@ -9399,8 +9399,10 @@ int cmd_pchg(int argc, char *argv[]) r->state < sizeof(pchg_state_text) ? pchg_state_text[r->state] : "UNDEF", r->state); - printf("Battery: %d%%\n", r->battery_percentage); - printf("Flags: 0x%x\n", r->error); + printf("Battery: %u%%\n", r->battery_percentage); + printf("Errors: 0x%x\n", r->error); + printf("FW Version: 0x%x\n", r->fw_version); + printf("Dropped events: %u\n", r->dropped_event_count); return 0; } |