summaryrefslogtreecommitdiff
path: root/include/host_command.h
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2012-05-26 13:35:01 -0700
committerGerrit <chrome-bot@google.com>2012-07-02 20:36:57 -0700
commite723318ec139e6729e4f2aa20cdde32f04960922 (patch)
treea53b5457938fc733f3ffdb085a936bf150326009 /include/host_command.h
parented9d6282d46d8216ae6f81477171324fcbdc94aa (diff)
downloadchrome-ec-e723318ec139e6729e4f2aa20cdde32f04960922.tar.gz
Remove unnecessary host_send_result()
This seems to be a hangover from the LPC protocol. We can send a result just by sending a response with no data. Drop this function and remove all uses of it. Also use 'enum ec_status' instead of int, since this is the correct response type. BUG=chrome-os-partner:10533 TEST=manual: build for all boards build and boot on daisy Change-Id: I93a029bd6ba8cec567b61af3b410bcead015b5c0 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/25980
Diffstat (limited to 'include/host_command.h')
-rw-r--r--include/host_command.h11
1 files changed, 3 insertions, 8 deletions
diff --git a/include/host_command.h b/include/host_command.h
index 245d39a162..ea31bdcc41 100644
--- a/include/host_command.h
+++ b/include/host_command.h
@@ -26,20 +26,15 @@ struct host_command {
command slots (0=kernel, 1=user). */
void host_command_received(int slot, int command);
-/* Send errors or success result code to a host command,
- * without response data.
- * <slot> is 0 for kernel-originated commands,
- * 1 for usermode-originated commands.
- * <result> is the error code. */
-void host_send_result(int slot, int result);
-
// success results with response data
/* Send a successful result code along with response data to a host command.
* <slot> is 0 for kernel-originated commands,
* 1 for usermode-originated commands.
+ * <result> is the result code for the command (EC_RES_...)
* <data> is the buffer with the response payload.
* <size> is the size of the response buffer. */
-void host_send_response(int slot, const uint8_t *data, int size);
+void host_send_response(int slot, enum ec_status result, const uint8_t *data,
+ int size);
/* Return a pointer to the host command data buffer. This buffer must
* only be accessed between a notification to host_command_received()