diff options
| author | Sean Abraham <seanabraham@chromium.org> | 2021-03-01 15:13:48 -0700 |
|---|---|---|
| committer | Sean Abraham <seanabraham@chromium.org> | 2021-03-01 22:59:54 +0000 |
| commit | 1e800ac838504c0d2950c7aa90cdfe7bde251545 (patch) | |
| tree | 64706ca3d77a1452ac653d40fb71e6ae9d6a34bc /docs/code_reviews.md | |
| parent | ef6a915de0a2b65c18c03074b66717d597675162 (diff) | |
| download | chrome-ec-master.tar.gz | |
docs: point md files in master to main/HEADmaster
Master md files are out of date. Point to main branch in case someone
lands in master branch from an old link.
BUG=b:180952272,b:180921286
BRANCH=None
TEST=Preview changes with gerrit
Exempt-From-Owner-Approval: fixing docs
Change-Id: I6583b6c7fc21248eb49a6cd71e077fbdb5de2435
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2727846
Reviewed-by: Sean Abraham <seanabraham@chromium.org>
Reviewed-by: Rob Barnes <robbarnes@google.com>
Auto-Submit: Sean Abraham <seanabraham@chromium.org>
Tested-by: Sean Abraham <seanabraham@chromium.org>
Diffstat (limited to 'docs/code_reviews.md')
| -rw-r--r-- | docs/code_reviews.md | 57 |
1 files changed, 4 insertions, 53 deletions
diff --git a/docs/code_reviews.md b/docs/code_reviews.md index 8bda5fe31a..79a0c6b9bf 100644 --- a/docs/code_reviews.md +++ b/docs/code_reviews.md @@ -1,54 +1,5 @@ -# Code Reviews +*** note +**Warning: This document is old & has moved. Please update any links:**<br> +https://chromium.googlesource.com/chromiumos/platform/ec/+/HEAD/docs/code_reviews.md +*** -The `platform/ec` repository makes use of a code review system that tries to -evenly distribute code reviews among available reviewers. - -[TOC] - -## How to request a review - -Add `cros-ec-reviewers@google.com` to the reviewer line in Gerrit. A background -job will come around and replace the `cros-ec-reviewers@google.com` address with -the next available reviewer in the EC reviewer rotation. This typically takes on -the order of minutes. - -Optionally, you can click the [FIND OWNERS] button in the UI, and select -`cros-ec-reviewers@google.com`. - -## When to use review system - -If you are modifying code in `common/`, `chip/`, or `core/`, feel free to use -the `cros-ec-reviewers@google.com` system. It is **never** a requirement to use -`cros-ec-reviewers@google.com`. You can always request a review from a specific -person. - -## Responsibilities of reviewers - -If the selected reviewer is unfamiliar with code in a CL, then that reviewer -should at least ensure that EC style and paradigms are being followed. Once EC -styles and paradigms are being followed, then the reviewer can give a +1 and add -the appropriate domain expert for that section of code. - -Reviewers should try to give an initial response within 1 business day of -receiving a review request. Thereafter, they should try to respond to new -comments by the author within 1 business day. - -## Review guidelines - -Authors and reviewers should follow the Chrome OS firmware review -[guidelines][2] while publishing and reviewing code. - -## How can I join the rotation? - -Add your name to the [list of reviewers][1]. - -## Reference - -* [Chrome OS firmware review guidelines][2] -* [Coreboot Gerrit Guidelines][3] -* [Google small CL guidelines][5] - -[1]: http://google3/chrome/crosinfra/gwsq/ec_reviewers -[2]: http://chromium.googlesource.com/chromiumos/docs/+/master/firmware_code_reviews.md -[3]: https://doc.coreboot.org/getting_started/gerrit_guidelines.html -[5]: https://google.github.io/eng-practices/review/developer/small-cls.html |