diff options
| author | Keith Short <keithshort@chromium.org> | 2020-07-01 17:38:40 -0600 |
|---|---|---|
| committer | Evan Benn <evanbenn@chromium.org> | 2020-07-02 03:50:09 +0000 |
| commit | 765f30881ec3e21a5724d16ffc32e25aecfe2f24 (patch) | |
| tree | 54495e2172890caac3f9fd5fb921fba5d1828e80 /common/usbc_ppc.c | |
| parent | 02fa7aa3134cab7a616069e7259cb63664aa1983 (diff) | |
| download | chrome-ec-765f30881ec3e21a5724d16ffc32e25aecfe2f24.tar.gz | |
ppc: string de-duplication
De-duplicate strings in PPC drivers. Saves 312 bytes on Volteer.
Average flash increase of 211 bytes.
BUG=b:158572770
BRANCH=none
TEST=make buildall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I5ca5c935f974b04216ce4d90e6f6d6b9103e8b75
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2278586
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'common/usbc_ppc.c')
| -rw-r--r-- | common/usbc_ppc.c | 20 |
1 files changed, 16 insertions, 4 deletions
diff --git a/common/usbc_ppc.c b/common/usbc_ppc.c index 17dacf7c09..765e028a65 100644 --- a/common/usbc_ppc.c +++ b/common/usbc_ppc.c @@ -16,9 +16,21 @@ #ifndef TEST_BUILD #define CPRINTF(format, args...) cprintf(CC_USBPD, format, ## args) #define CPRINTS(format, args...) cprints(CC_USBPD, format, ## args) + +int ppc_prints(const char *string, int port) +{ + return CPRINTS("ppc p%d %s", port, string); +} + +int ppc_err_prints(const char *string, int port, int error) +{ + return CPRINTS("ppc p%d %s (%d)", port, string, error); +} #else #define CPRINTF(args...) #define CPRINTS(args...) +#define ppc_prints(string, port) +#define ppc_err_prints(string, port, error) #endif /* @@ -46,9 +58,9 @@ int ppc_init(int port) if (ppc->drv->init) { rv = ppc->drv->init(port); if (rv) - CPRINTS("p%d: PPC init failed! (%d)", port, rv); + ppc_err_prints("init failed!", port, rv); else - CPRINTS("p%d: PPC init'd.", port); + ppc_prints("init'd.", port); } return rv; @@ -67,7 +79,7 @@ int ppc_add_oc_event(int port) atomic_clear(&connected_ports, 1 << port); if (oc_event_cnt_tbl[port] >= PPC_OC_CNT_THRESH) - CPRINTS("C%d: OC event limit reached! " + ppc_prints("OC event limit reached! " "Source path disabled until physical disconnect.", port); return EC_SUCCESS; @@ -85,7 +97,7 @@ static void clear_oc_tbl(void) if ((!(BIT(port) & connected_ports)) && oc_event_cnt_tbl[port]) { oc_event_cnt_tbl[port] = 0; - CPRINTS("C%d: OC events cleared", port); + ppc_prints("OC events cleared", port); } } DECLARE_DEFERRED(clear_oc_tbl); |