diff options
author | Randall Spangler <rspangler@chromium.org> | 2012-03-16 16:08:09 -0700 |
---|---|---|
committer | Randall Spangler <rspangler@chromium.org> | 2012-03-19 09:05:07 -0700 |
commit | 9ff6f390b9584e2b6e08a08096abc386d7832adb (patch) | |
tree | 3b4ea8675c4d4bea2203b1c9a019475c4fa81461 /common/port80.c | |
parent | 2a9f80d2d990816fe1e5bb1222a6b294673ce7b2 (diff) | |
download | chrome-ec-9ff6f390b9584e2b6e08a08096abc386d7832adb.tar.gz |
Remove code for skipping duplicate port 80 writes
The kernel no longer uses port 80 as a delay mechanism, so we don't
need to detect the no-longer-present spammy writes.
Signed-off-by: Randall Spangler <rspangler@chromium.org>
BUG=chrome-os-partner:7972
TEST=port80 scroll, then boot the system. see a few repeated bytes,
but not piles of 00 and ff's.
Change-Id: Id14dc43ab4e1b15c6bab99a17c062f295a59e7e6
Diffstat (limited to 'common/port80.c')
-rw-r--r-- | common/port80.c | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/common/port80.c b/common/port80.c index 34b418d76d..331ea23a48 100644 --- a/common/port80.c +++ b/common/port80.c @@ -20,19 +20,10 @@ static int scroll = 0; void port_80_write(int data) { -#ifndef CONFIG_PORT80_PRINT_DUPLICATES - static int last_data = -1; /* Last data written to port 80 */ - - /* Ignore duplicate writes, since the linux kernel writes to port 80 - * as a delay mechanism during boot. */ - if (data == last_data) - return; - - last_data = data; -#endif - - /* TODO: post to SWI and print from there? This currently - * prints from inside the LPC interrupt itself. */ + /* Note that this currently prints from inside the LPC interrupt + * itself. Probably not worth the system overhead to buffer the data + * and print it from a task, because we're printing a small amount of + * data and uart_printf() doesn't block. */ uart_printf("%c[Port 80: 0x%02x]", scroll ? '\n' : '\r', data); history[head] = data; |