diff options
| author | Edward Hill <ecgh@chromium.org> | 2020-10-02 14:36:55 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-10-03 01:19:48 +0000 |
| commit | 0d0c0cbf530f41bc61d8781bc51168b7ee47ddbb (patch) | |
| tree | 3b523c3c5682efc53e2aad158e683a3f0415e688 /common/charge_ramp.c | |
| parent | 6604329314d9ba2c10de111fd2b64a49366746cc (diff) | |
| download | chrome-ec-0d0c0cbf530f41bc61d8781bc51168b7ee47ddbb.tar.gz | |
charge_ramp: Don't use SW ramp for USB-C chargers
Don't use SW ramp for USB-C chargers (CHARGE_SUPPLIER_PD and
CHARGE_SUPPLIER_TYPEC) since the slow ramp causes issues with auto
power on. This means we rely on the chargers to be able to supply
the full current they advertise.
BUG=b:169634979 b:163864475 b:167257846
BRANCH=zork
TEST=cutoff battery, plug ac, boot to OS
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I9b7ae79ebcfdf0e8b8b136555a907eef423361ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2445462
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'common/charge_ramp.c')
| -rw-r--r-- | common/charge_ramp.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/common/charge_ramp.c b/common/charge_ramp.c index ee8f846a5a..a408771f40 100644 --- a/common/charge_ramp.c +++ b/common/charge_ramp.c @@ -18,11 +18,16 @@ test_mockable int chg_ramp_allowed(int port, int supplier) return 0; switch (supplier) { + /* Use ramping for USB-C DTS suppliers (debug accessory eg suzy-q). */ case CHARGE_SUPPLIER_TYPEC_DTS: - /* Need ramping for USB-C chargers as well to avoid voltage droops. */ + return 1; + /* + * Use HW ramping for USB-C chargers. Don't use SW ramping since the + * slow ramp causes issues with auto power on (b/169634979). + */ case CHARGE_SUPPLIER_PD: case CHARGE_SUPPLIER_TYPEC: - return 1; + return IS_ENABLED(CONFIG_CHARGE_RAMP_HW); /* default: fall through */ } |