diff options
| author | Patrick Georgi <pgeorgi@google.com> | 2018-08-01 13:17:13 +0200 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-08-01 19:35:12 -0700 |
| commit | 3f6fc95c0c55ad8d562c79022cd68823d15a5c93 (patch) | |
| tree | 00da2aae0e253c3a3863233622f5a70e91b2b7ca /chip/mec1322 | |
| parent | 295ccc36eaa01eccb0db2079122ca12cdec55044 (diff) | |
| download | chrome-ec-3f6fc95c0c55ad8d562c79022cd68823d15a5c93.tar.gz | |
chip/mec1322: properly compare timestamps
(uint32_t)(uint32_t - uint32_t) >= 0 is always true.
Change-Id: I95343379ed76e6ea338e95600006867a1835943a
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Found-by: Coverity Scan #142090
Reviewed-on: https://chromium-review.googlesource.com/1158413
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'chip/mec1322')
| -rw-r--r-- | chip/mec1322/lfw/ec_lfw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chip/mec1322/lfw/ec_lfw.c b/chip/mec1322/lfw/ec_lfw.c index b99d33d011..86a4949e17 100644 --- a/chip/mec1322/lfw/ec_lfw.c +++ b/chip/mec1322/lfw/ec_lfw.c @@ -126,7 +126,7 @@ int timestamp_expired(timestamp_t deadline, const timestamp_t *now) now = &now_val; } - return ((uint32_t)(now->le.lo - deadline.le.lo) >= 0); + return now->le.lo >= deadline.le.lo; } |