From 3f6fc95c0c55ad8d562c79022cd68823d15a5c93 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Wed, 1 Aug 2018 13:17:13 +0200 Subject: chip/mec1322: properly compare timestamps (uint32_t)(uint32_t - uint32_t) >= 0 is always true. Change-Id: I95343379ed76e6ea338e95600006867a1835943a Signed-off-by: Patrick Georgi Found-by: Coverity Scan #142090 Reviewed-on: https://chromium-review.googlesource.com/1158413 Commit-Ready: Patrick Georgi Tested-by: Patrick Georgi Reviewed-by: Daisuke Nojiri --- chip/mec1322/lfw/ec_lfw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'chip/mec1322') diff --git a/chip/mec1322/lfw/ec_lfw.c b/chip/mec1322/lfw/ec_lfw.c index b99d33d011..86a4949e17 100644 --- a/chip/mec1322/lfw/ec_lfw.c +++ b/chip/mec1322/lfw/ec_lfw.c @@ -126,7 +126,7 @@ int timestamp_expired(timestamp_t deadline, const timestamp_t *now) now = &now_val; } - return ((uint32_t)(now->le.lo - deadline.le.lo) >= 0); + return now->le.lo >= deadline.le.lo; } -- cgit v1.2.1