diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-08-22 17:55:12 -0700 |
|---|---|---|
| committer | Bill Richardson <wfrichar@chromium.org> | 2016-08-24 16:30:10 +0000 |
| commit | bb15561db56728b83ee7fe35e534da7577a7729d (patch) | |
| tree | e586ee3b18c8fda464da38b42a06845f0d7f6786 /chip/it83xx | |
| parent | f322e32a3ec052be3f0c226145448fed63aa7ef9 (diff) | |
| download | chrome-ec-bb15561db56728b83ee7fe35e534da7577a7729d.tar.gz | |
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.
We're never going to use this, let's just get rid of it.
BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware
Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.
Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'chip/it83xx')
| -rw-r--r-- | chip/it83xx/clock.c | 6 | ||||
| -rw-r--r-- | chip/it83xx/peci.c | 6 | ||||
| -rw-r--r-- | chip/it83xx/system.c | 3 |
3 files changed, 5 insertions, 10 deletions
diff --git a/chip/it83xx/clock.c b/chip/it83xx/clock.c index a63a86ec0a..60549c81fe 100644 --- a/chip/it83xx/clock.c +++ b/chip/it83xx/clock.c @@ -438,8 +438,7 @@ static int command_idle_stats(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(idlestats, command_idle_stats, "", - "Print last idle stats", - NULL); + "Print last idle stats"); /** * Configure deep sleep clock settings. @@ -486,6 +485,5 @@ DECLARE_CONSOLE_COMMAND(dsleep, command_dsleep, "Use 'off' to allow deep sleep to use heavysleep whenever\n" "conditions allow.\n" "Give a timeout value for the console in use timeout.\n" - "See also 'sleepmask'.", - NULL); + "See also 'sleepmask'."); #endif /* CONFIG_LOW_POWER_IDLE */ diff --git a/chip/it83xx/peci.c b/chip/it83xx/peci.c index 7682ddbcfe..b8e0b7c451 100644 --- a/chip/it83xx/peci.c +++ b/chip/it83xx/peci.c @@ -403,8 +403,7 @@ static int peci_cmd(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(peci, peci_cmd, "addr wlen rlen cmd timeout(us)", - "PECI command", - NULL); + "PECI command"); static int command_peci_temp(int argc, char **argv) { @@ -418,5 +417,4 @@ static int command_peci_temp(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(pecitemp, command_peci_temp, NULL, - "Print CPU temperature", - NULL); + "Print CPU temperature"); diff --git a/chip/it83xx/system.c b/chip/it83xx/system.c index f4ce1d6be9..64d6c09157 100644 --- a/chip/it83xx/system.c +++ b/chip/it83xx/system.c @@ -356,5 +356,4 @@ static int command_rw_ec_reg(int argc, char **argv) DECLARE_CONSOLE_COMMAND(rwreg, command_rw_ec_reg, "addr [value (byte)]", "R/W EC/PNPCFG registers." - " addr 0xec21xxyy for R/W PNPCFG, xx is LDN yy is IDX", - NULL); + " addr 0xec21xxyy for R/W PNPCFG, xx is LDN yy is IDX"); |