diff options
author | Wai-Hong Tam <waihong@google.com> | 2021-08-03 17:17:56 -0700 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2021-08-05 00:13:33 +0000 |
commit | 2eb53a39662b905c65015bafb5f73ab2324d369c (patch) | |
tree | 6352433557cdb05c75b1eef449c9ecf844bfc3d0 /board/kracko/board.c | |
parent | fc016f2dce16d0555deee69e00ea5a626eb27f21 (diff) | |
download | chrome-ec-2eb53a39662b905c65015bafb5f73ab2324d369c.tar.gz |
lid_angle: Create a common callback for lid angle changes
Each board defines its own callback lid_angle_peripheral_enable().
The implementation is very similar. Create a common implementation
and reduce the duplicated code.
This CL removes the board callbacks which are identifical to the
common callback. If it is slightly different, keep it and add
the __override tag.
The check of TEST_BUILD is unnecessary as the board callback is not
linked in the test build.
BRANCH=None
BUG=b:194922043
TEST=Build all the images.
Change-Id: I73d381730f35b80eff69399cdfc5fb54f839aee0
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3069175
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'board/kracko/board.c')
-rw-r--r-- | board/kracko/board.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/board/kracko/board.c b/board/kracko/board.c index a3d039327d..99dcd56810 100644 --- a/board/kracko/board.c +++ b/board/kracko/board.c @@ -705,9 +705,8 @@ const struct temp_sensor_t temp_sensors[] = { }; BUILD_ASSERT(ARRAY_SIZE(temp_sensors) == TEMP_SENSOR_COUNT); -#ifndef TEST_BUILD /* This callback disables keyboard when convertibles are fully open */ -void lid_angle_peripheral_enable(int enable) +__override void lid_angle_peripheral_enable(int enable) { int chipset_in_s0 = chipset_in_state(CHIPSET_STATE_ON); @@ -731,7 +730,6 @@ void lid_angle_peripheral_enable(int enable) keyboard_scan_enable(0, KB_SCAN_DISABLE_LID_ANGLE); } } -#endif __override void ocpc_get_pid_constants(int *kp, int *kp_div, int *ki, int *ki_div, |