diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2020-02-21 14:39:11 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-02-22 04:13:49 +0000 |
| commit | 589cd65310dbff8c44fb9e5da5b28d49d4094ce5 (patch) | |
| tree | e22eb64e2493a6bff0b8e6e538c2956756f9bad9 | |
| parent | aebb58b99064567f25b1c407aeb5d193dc4042c3 (diff) | |
| download | chrome-ec-589cd65310dbff8c44fb9e5da5b28d49d4094ce5.tar.gz | |
dedede: Configure EN_VCCST as input
Currently, the EC isn't using EN_VCCST itself, but we are using
external logic to set this pin. The pin is initialized to low on the
EC which causes a drive fight.
This commit changes GPIO_EN_VCCST to an input while we determine
whether or not we will use this pin in the EC.
BUG=b:149775160
BRANCH=None
TEST=`make -j buildall`
TEST=Build and flash waddledoo, verify EC cannot set EN_VCCST.
Change-Id: Ia9f439d3d049580ac66689fdde11ed75ca044584
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068801
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
| -rw-r--r-- | board/waddledee/gpio.inc | 3 | ||||
| -rw-r--r-- | board/waddledoo/gpio.inc | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/board/waddledee/gpio.inc b/board/waddledee/gpio.inc index 24c3fae63b..6d86813bf9 100644 --- a/board/waddledee/gpio.inc +++ b/board/waddledee/gpio.inc @@ -55,7 +55,8 @@ GPIO(EN_PP3300_PEN, PIN(E, 6), GPIO_OUT_LOW) GPIO(EN_PP3300_A, PIN(C, 5), GPIO_OUT_LOW) GPIO(EC_AP_PCH_PWROK_OD, PIN(D, 6), GPIO_ODR_LOW) GPIO(EN_PP5000_U, PIN(K, 5), GPIO_OUT_LOW) -GPIO(EN_VCCST, PIN(D, 4), GPIO_OUT_LOW) +/* TODO(b:149775160) - Modify if needed if we ever use this signal. */ +GPIO(EN_VCCST, PIN(D, 4), GPIO_INPUT) GPIO(EN_VCCIO_EXT, PIN(B, 2), GPIO_OUT_LOW) GPIO(EC_PROCHOT_ODL, PIN(I, 1), GPIO_ODR_HIGH | GPIO_SEL_1P8V) GPIO(EC_AP_VCCST_PWRGD_OD, PIN(E, 5), GPIO_ODR_LOW) diff --git a/board/waddledoo/gpio.inc b/board/waddledoo/gpio.inc index 97fb3cf80a..98eca3109c 100644 --- a/board/waddledoo/gpio.inc +++ b/board/waddledoo/gpio.inc @@ -59,7 +59,8 @@ GPIO(EC_SUB_IO_2, PIN(3, 4), GPIO_OUT_LOW) /* Misc Enables */ GPIO(EN_VCCIO_EXT, PIN(6, 1), GPIO_OUT_LOW) -GPIO(EN_VCCST, PIN(A, 7), GPIO_OUT_LOW) +/* TODO(b:149775160) - Modify if needed if we ever use this signal. */ +GPIO(EN_VCCST, PIN(A, 7), GPIO_INPUT) GPIO(EN_PP3300_PEN, PIN(6, 3), GPIO_OUT_LOW) GPIO(EN_PP3300_A, PIN(0, 3), GPIO_OUT_LOW) GPIO(EN_PP5000_U, PIN(7, 3), GPIO_OUT_LOW) |