diff options
| author | Vic Yang <victoryang@chromium.org> | 2013-06-10 21:54:23 +0800 |
|---|---|---|
| committer | ChromeBot <chrome-bot@google.com> | 2013-06-11 02:25:24 -0700 |
| commit | 465b59342a026d231ffef0cfcc1efc9c8e55a4f4 (patch) | |
| tree | 5c6b9b16b9d1e9396add1135dee83de6d95e6c98 | |
| parent | 9b981bf1afe1b8c08c46f5911e8e7269349088d3 (diff) | |
| download | chrome-ec-stabilize-4255.B.tar.gz | |
Only cache LP5562 status on I2C transaction successstabilize-4255.B
If the I2C transaction fails, we shouldn't cache the status because that
status is not set correctly in LP5562.
BUG=chrome-os-partner:20020
TEST=Boot and check battery LED still works.
BRANCH=spring
Change-Id: I3f40c2d5c85db41e4ba4b80dc5252e5d86100823
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/58072
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
| -rw-r--r-- | common/lp5562_battery_led.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/common/lp5562_battery_led.c b/common/lp5562_battery_led.c index 3aebeb0b76..d8b9a628fd 100644 --- a/common/lp5562_battery_led.c +++ b/common/lp5562_battery_led.c @@ -111,6 +111,7 @@ static void battery_led_update(void) { int current; int desired_current; + int rv; enum led_state_t state = LED_STATE_OFF; /* Current states and next states */ @@ -120,13 +121,14 @@ static void battery_led_update(void) /* Determine LED power */ new_led_power = extpower_is_present(); if (new_led_power != led_power) { - led_power = new_led_power; if (new_led_power) { - lp5562_poweron(); + rv = lp5562_poweron(); } else { - lp5562_poweroff(); + rv = lp5562_poweroff(); set_led_color(LED_STATE_OFF); } + if (!rv) + led_power = new_led_power; } if (!new_led_power) return; |