summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Hughes <tomhughes@chromium.org>2020-05-12 10:43:53 -0700
committerCommit Bot <commit-bot@chromium.org>2020-05-14 19:51:33 +0000
commit4be909bf3b6e4cf1b131a8da8f023cd01f9df641 (patch)
treef3b13df4e1d71068c66004ac62b75c2ee72c5d6e
parent1d932d54000a48cef8e168d9316e7aa22c25afa2 (diff)
downloadchrome-ec-4be909bf3b6e4cf1b131a8da8f023cd01f9df641.tar.gz
rollback: const correctness
Entropy being added is never modified. BRANCH=none BUG=none TEST=make buildall -j Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I2b54334812c9a86fad059576725e6212e88c2ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2197334 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
-rw-r--r--common/rollback.c6
-rw-r--r--include/rollback.h2
2 files changed, 4 insertions, 4 deletions
diff --git a/common/rollback.c b/common/rollback.c
index e310aa904b..95fa86f9fd 100644
--- a/common/rollback.c
+++ b/common/rollback.c
@@ -202,7 +202,7 @@ failed:
#ifdef CONFIG_ROLLBACK_SECRET_SIZE
static int add_entropy(uint8_t *dst, const uint8_t *src,
- uint8_t *add, unsigned int add_len)
+ const uint8_t *add, unsigned int add_len)
{
int ret = 0;
#ifdef CONFIG_SHA256
@@ -254,7 +254,7 @@ failed:
* @return EC_SUCCESS on success, EC_ERROR_* on error.
*/
static int rollback_update(int32_t next_min_version,
- uint8_t *entropy, unsigned int length)
+ const uint8_t *entropy, unsigned int length)
{
/*
* When doing flash_write operation, the data needs to be in blocks
@@ -356,7 +356,7 @@ int rollback_update_version(int32_t next_min_version)
return rollback_update(next_min_version, NULL, 0);
}
-int rollback_add_entropy(uint8_t *data, unsigned int len)
+int rollback_add_entropy(const uint8_t *data, unsigned int len)
{
return rollback_update(-1, data, len);
}
diff --git a/include/rollback.h b/include/rollback.h
index b367bb4ef5..8e439eaac3 100644
--- a/include/rollback.h
+++ b/include/rollback.h
@@ -47,7 +47,7 @@ int rollback_update_version(int32_t next_min_version);
*
* @return EC_SUCCESS on success, EC_ERROR_* on error.
*/
-int rollback_add_entropy(uint8_t *data, unsigned int len);
+int rollback_add_entropy(const uint8_t *data, unsigned int len);
/**
* Lock rollback protection block, reboot if necessary.