From 4be909bf3b6e4cf1b131a8da8f023cd01f9df641 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Tue, 12 May 2020 10:43:53 -0700 Subject: rollback: const correctness Entropy being added is never modified. BRANCH=none BUG=none TEST=make buildall -j Signed-off-by: Tom Hughes Change-Id: I2b54334812c9a86fad059576725e6212e88c2ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2197334 Reviewed-by: Nicolas Boichat --- common/rollback.c | 6 +++--- include/rollback.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/common/rollback.c b/common/rollback.c index e310aa904b..95fa86f9fd 100644 --- a/common/rollback.c +++ b/common/rollback.c @@ -202,7 +202,7 @@ failed: #ifdef CONFIG_ROLLBACK_SECRET_SIZE static int add_entropy(uint8_t *dst, const uint8_t *src, - uint8_t *add, unsigned int add_len) + const uint8_t *add, unsigned int add_len) { int ret = 0; #ifdef CONFIG_SHA256 @@ -254,7 +254,7 @@ failed: * @return EC_SUCCESS on success, EC_ERROR_* on error. */ static int rollback_update(int32_t next_min_version, - uint8_t *entropy, unsigned int length) + const uint8_t *entropy, unsigned int length) { /* * When doing flash_write operation, the data needs to be in blocks @@ -356,7 +356,7 @@ int rollback_update_version(int32_t next_min_version) return rollback_update(next_min_version, NULL, 0); } -int rollback_add_entropy(uint8_t *data, unsigned int len) +int rollback_add_entropy(const uint8_t *data, unsigned int len) { return rollback_update(-1, data, len); } diff --git a/include/rollback.h b/include/rollback.h index b367bb4ef5..8e439eaac3 100644 --- a/include/rollback.h +++ b/include/rollback.h @@ -47,7 +47,7 @@ int rollback_update_version(int32_t next_min_version); * * @return EC_SUCCESS on success, EC_ERROR_* on error. */ -int rollback_add_entropy(uint8_t *data, unsigned int len); +int rollback_add_entropy(const uint8_t *data, unsigned int len); /** * Lock rollback protection block, reboot if necessary. -- cgit v1.2.1