diff options
| author | Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com> | 2018-12-22 15:24:28 +0800 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2019-02-27 02:03:30 +0000 |
| commit | ce76585577948d45926f8c820be3d23b4ee46d14 (patch) | |
| tree | 1f7661bf52090cde2459af7fb4f9dc9b84b57cd6 | |
| parent | b8c72680e5246f0a1faf0d94e58b64794c8d9250 (diff) | |
| download | chrome-ec-ce76585577948d45926f8c820be3d23b4ee46d14.tar.gz | |
OZ554: set power up sequence.
1. Spec says backlight should be turned on after 500ms
after eDP signals are ready.
2. There's no way to get exact eDP ready time, therefore,
give one second delay.
power up __/----------------
eDP ______/------------
backlight _____________/-----
|- t1 -| : >=500 ms
|- t2 -| : 1 second is enough
BUG=b:120237453
BRANCH=ToT
TEST=Test results is in crosbug 120237453, comment #31
Signed-off-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com>
Change-Id: I63e4536a9d8a7e5febf4ee76f05cbe7c014c7faa
Reviewed-on: https://chromium-review.googlesource.com/1389975
Commit-Ready: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com>
Tested-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
(cherry picked from commit 219b09e87f61ffb410fe1a1dbaed4983460fefb4)
Reviewed-on: https://chromium-review.googlesource.com/c/1490792
Commit-Queue: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com>
| -rw-r--r-- | driver/led/oz554.c | 16 | ||||
| -rw-r--r-- | driver/led/oz554.h | 4 |
2 files changed, 19 insertions, 1 deletions
diff --git a/driver/led/oz554.c b/driver/led/oz554.c index 4a1c46da0c..aa50028420 100644 --- a/driver/led/oz554.c +++ b/driver/led/oz554.c @@ -99,7 +99,21 @@ DECLARE_DEFERRED(backlight_enable_deferred); void backlight_enable_interrupt(enum gpio_signal signal) { - hook_call_deferred(&backlight_enable_deferred_data, 30 * MSEC); + /* + * 1. Spec says backlight should be turned on after 500ms + * after eDP signals are ready. + * + * 2. There's no way to get exact eDP ready time, therefore, + * give one second delay. + * + * power up __/---------------- + * eDP ______/------------ + * backlight _____________/----- + * |- t1 -| : >=500 ms + * |- t2 -| : 1 second is enough + */ + hook_call_deferred(&backlight_enable_deferred_data, + OZ554_POWER_BACKLIGHT_DELAY); } int oz554_set_config(int offset, int data) diff --git a/driver/led/oz554.h b/driver/led/oz554.h index bb45a17f30..009728ba73 100644 --- a/driver/led/oz554.h +++ b/driver/led/oz554.h @@ -21,6 +21,10 @@ void oz554_board_init(void) __attribute__((weak)); */ int oz554_set_config(int offset, int data); +#ifndef OZ554_POWER_BACKLIGHT_DELAY +#define OZ554_POWER_BACKLIGHT_DELAY SECOND +#endif + void backlight_enable_interrupt(enum gpio_signal signal); #endif |