summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam Hurst <shurst@google.com>2019-12-05 13:58:18 -0800
committerCommit Bot <commit-bot@chromium.org>2019-12-21 00:01:14 +0000
commitc0c2e6227b0c5a416784664aa42dc7a8fbd5b6a5 (patch)
tree99052146bfa2272f5bb767bc56c94684cea12b4d
parentc08c37252fda3af80dc5dea01ee2b64920ece857 (diff)
downloadchrome-ec-c0c2e6227b0c5a416784664aa42dc7a8fbd5b6a5.tar.gz
TCPMv2: Don't turn off VCONN during a PR_SWAP
A flag that tracks PR_SWAP was being prematurely cleared, causing VCONN to turn off. BUG=chromium:1031304 BRANCH=none TEST=make -j buildall manual tests: Using a kohaku and a Kensington dock, I verified that VCONN does not turn off during a PR_SWAP Change-Id: I2947bd50f299684d58f4cbdcd9c649f395c3d7d2 Signed-off-by: Sam Hurst <shurst@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1954311 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1979559 Tested-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org>
-rw-r--r--common/usbc/usb_tc_drp_acc_trysrc_sm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/usbc/usb_tc_drp_acc_trysrc_sm.c b/common/usbc/usb_tc_drp_acc_trysrc_sm.c
index a025aad2fb..a3e6f5f67f 100644
--- a/common/usbc/usb_tc_drp_acc_trysrc_sm.c
+++ b/common/usbc/usb_tc_drp_acc_trysrc_sm.c
@@ -2749,7 +2749,7 @@ static void tc_attached_src_run(const int port)
* Power Role Swap Request
*/
if (TC_CHK_FLAG(port, TC_FLAGS_DO_PR_SWAP)) {
- TC_CLR_FLAG(port, TC_FLAGS_DO_PR_SWAP);
+ /* Clear TC_FLAGS_DO_PR_SWAP on exit */
return set_state_tc(port, TC_ATTACHED_SNK);
}