| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
DBUS_ERROR_UNKNOWN_OBJECT, etc. have been defined for more than a decade now.
No need to check for them.
|
| |
|
|
|
|
|
|
|
|
|
| |
The iterator for retrieving all properties doesn't handle a getter failing,
which happens if the AtkObject doesn't implement the atk interface
corresponding to the dbus interface. This leads to the application aborting
on account of a malformed DBusMessage.
Helps #20
|
|
|
|
| |
Fixes https://gitlab.gnome.org/GNOME/at-spi2-atk/issues/2
|
| |
|
|
|
|
|
| |
The leak fix in commit c45b5870 removed a return in an error path. Let's
put it back.
|
|
|
|
| |
Avoid the compiler warning us that `out` is defined but unused.
|
| |
|
| |
|
|
|
|
|
|
|
| |
Meson is a fast, portable, easy to understand meta-build system. It is
currently being adopted in various projects inside GNOME alongside
Autotools, in the hope of making it the default build system for future
releases.
|
| |
|
|
|
|
|
|
| |
We need to free the pointer array here, along with the path.
https://bugzilla.gnome.org/show_bug.cgi?id=689887
|
|
|
|
|
|
|
|
| |
Frees all allocated memory.
g_ptr_array_free(..., FALSE) was probably being called to avoid a destructor being called on the elements of the array that point to static data. But that method returns an array that must still be g_free()d.
https://bugzilla.gnome.org/show_bug.cgi?id=688363
|
|
|
|
|
|
|
|
| |
The droute test was broken (it had not been updated for recent API
changes and also did not return a non-zero exit code on failure). Also,
it is the only thing in at-spi2-atk that uses dbind, so re-worked it to
call libdbus directly, so that we can remove dbind / avoid having it
both here and in at-spi2-core.
|
|
|
|
|
|
| |
Unused variables and discarding 'const' qualifier.
https://bugzilla.gnome.org/show_bug.cgi?id=678045
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the past, a gtk button's do_action handler added an idle to invoke
the button and then returned, but now the idle has been removed, and the
do_action call activates the button directly, meaning that, if the
button invokes a dialogue, then atk_action_do_action will not return
until the dialog closes. So, to be safe, we need to send a reply before
invoking atk. This means that atk's return value gets ignored, although
it was somewhat meaningless in gtk's case anyhow. This required that
droute's behavior be changed so that, if a handler does not return a
message, droute will now assume that the handler already sent a reply,
rather than synthesizing a default empty reply. Thus, handlers are now
required to return a value DBusMessage.
Perhaps the API should really be asynchronous, with a callback to be
invoked when the action finishes.
|
|
|
|
|
|
|
| |
If gnome_accessibility_module_shutdown was called and followed by a call
to gnome_accessibility_module_init, then things would go awry because of
various resources not being freed. Fixed several of these issues,
although some issues might remain.
|
| |
|
|
|
|
|
|
|
| |
- cache-adaptor.c makes use of AtkStateSet* .
- atk-bridge uses X.
- -Werror-implicit-function-declaration doesn't contain an equal sign in
my copy of gcc, and is gcc specific.
|
|
|
|
|
|
| |
When we receive strings from atk, we should ensure that they are valid UTF-8
before sending them over D-Bus, since bad UTF-8 will cause dbus-daemon to
kill the connection.
|
| |
|
|
|
|
|
|
| |
If a new version of libdbus is available, use DBUS_ERROR_UNKNOWN_OBJECT,
DBUS_ERROR_UNKNOWN_PROPERTY, and DBUS_ERROR_PROPERTY_READ_ONLY when
appropriate.
|
|
|
|
|
|
|
|
|
|
| |
Remove function to get the accessibility bus, since it was duplicating code
in at-spi2-core and should be modified for BGO#644851.
Also, use atspi_dbus_*_setup_with_g_main instead of depending on dbus-glib,
so that FDO#35115 doesn't show up and we don't need to disable p2p if an old
version of dbus-glib is installed.
Note that at-spi2-atk now depends on libatspi where previously it did not.
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=637398
|
|
|
|
|
|
| |
The main loop switching code will result in a hang in dbus-glib 0.88 and
earlier because of FDO#30574, so added a configure check to warn and disable
p2p for older dbus-glib versions.
|
| |
|
| |
|
|
|
|
| |
FDO#29365
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
the introspection XML in at-spi2-core.
|
| |
|
|
|
|
| |
Add an application reference to the event structure.
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involved:
Separating the 'cache' and registration
of accessible objects. This is because
the leased objects need to be available over
D-Bus but are not cached.
Separating the cache updating from the 'events'.
This is because we should still recieve updates on
leased accessibles, but they are not cached.
|
|
|
|
| |
a shared directory under 'at-spi2'.
|
|
|
|
| |
Previously these were shared libraries in at-spi2-core.
|
|
|
|
|
| |
Re-organize the build configuration to use an external registryd,
dbind and droute libraries from at-spi2-core.
|
|
|
|
|
|
|
|
|
| |
* droute/droute.c
Despite what people may believe all D-Bus
method calls must have a reply, whether the
client side is waiting for one or not.
This fixes droute so that it always sends
a reply to method calls.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* atk-adaptor/accessible-marshaller.c: Return SPI_DBUS_PATH_NULL
for a NULL object.
Fix call to dbus_message_iter_append_basic.
* atk-adaptor/accessible-register.c:
* atk-adaptor/editabletext-adaptor.c: Have copyText return a value.
* atk-adaptor/editabletext-adaptor.c: Fix uninitialized variable in
getAttributeValue.
Fix parameter type in getBoundedRanges, and open the appropriate
container when returning a value.
* value-adaptor.c: Return variants to conform with Properties iface.
* droute/droute.c: Throw exception if get fails.
When setting a property, correctly initialize the iter before reading.
* registry/deviceeventcontroller.c: deviceListener ->
deviceEventListener.
* spi-common/spi-dbus.h: Set SPI_DBUS_PATH_NULL to
/org/freedesktop/atspi/accessible/null.
|
|
|
|
|
|
| |
Fix some warnings when -Wall used.
These included non-void functions with
no return values that caused make distcheck to fail.
|
|
|
|
|
|
|
|
|
|
|
| |
* droute/droute.c
droute/droute.h
Add two new convinience functions for out
of memory and bad arguments D-Bus errors.
* pyatspi/__init__.py
Add a top level module 'Accessibility' to remain
compatible with the CORBA pyatspi.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mega commit that changes droute, adding
an interface for creating a droute context
and registering single, or multiple objects
with the droute context. Modifies atk-adaptor
and registryd to use the new interface.
* droute/
New interface
* atk-adaptor
Use new droute interface
* registryd
Use new droute interface
* pyatspi
Bug fix, methods were using "null" interface.
|
|
|
|
|
|
|
|
|
| |
* dbind/*
droute/*
Complete refactoring droute to add api for
creating single objects and object classes.
Minor refactor of dbind, adding interface
for marshalling signals.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Assorted changed to get the reorganized source tree
working.
*atk-adaptor/
Move the object registry functionality from spi-dbus
here as it was not used by the registryd.
*spi-common/
Move object registry funtionality out to adaptor.
*configure.ac droute/Makefile.am xml/Makefile.am
Provide a matching install path and default
search path for the introspection files.
*xml/introspection/org.freedesktop.atspi.Tree
Remove as this file is not autogenerated.
|
|
Re-organize the directories. The main purpose of
this change is to remove CORBA code and references
that are no longer used.
* atk-adaptor/
Code here used to live in libspi and atk-bridge.
* droute/
The droute module has been moved from libspi to
its own directory.
* spi-common
Code and definitions common to registryd and
the atk-adaptor. Mostly moved from libspi/dbus.c
and accessible.h.
* cspi/
Removed for the moment. Will have to be
mostly rewritten for D-Bus.
|