diff options
author | Mike Gorse <mgorse@suse.com> | 2013-05-02 15:24:22 -0500 |
---|---|---|
committer | Mike Gorse <mgorse@suse.com> | 2013-05-02 15:24:22 -0500 |
commit | c45b58703c60511c9ed94734573cdf44c3f4eedc (patch) | |
tree | 8dadc405693af434a4c8f5cc061baddedac82da5 /droute | |
parent | 5515673936c5fa9af85e133ed070349db5fb098a (diff) | |
download | at-spi2-atk-c45b58703c60511c9ed94734573cdf44c3f4eedc.tar.gz |
More DBusError leak fixes
Diffstat (limited to 'droute')
-rw-r--r-- | droute/droute.c | 22 |
1 files changed, 18 insertions, 4 deletions
diff --git a/droute/droute.c b/droute/droute.c index 82eea8f..838aacd 100644 --- a/droute/droute.c +++ b/droute/droute.c @@ -265,7 +265,12 @@ impl_prop_GetAll (DBusMessage *message, dbus_error_init (&error); if (!dbus_message_get_args (message, &error, DBUS_TYPE_STRING, &iface, DBUS_TYPE_INVALID)) - return dbus_message_new_error (message, DBUS_ERROR_FAILED, error.message); + { + DBusMessage *ret; + ret = dbus_message_new_error (message, DBUS_ERROR_FAILED, error.message); + dbus_error_free (&error); + return ret; + } reply = dbus_message_new_method_return (message); if (!reply) @@ -321,17 +326,26 @@ impl_prop_GetSet (DBusMessage *message, DBUS_TYPE_STRING, &(pair.two), DBUS_TYPE_INVALID)) - return dbus_message_new_error (message, DBUS_ERROR_FAILED, error.message); + { + DBusMessage *ret; + ret = dbus_message_new_error (message, DBUS_ERROR_FAILED, error.message); + dbus_error_free (&error); + } _DROUTE_DEBUG ("DRoute (handle prop): %s|%s on %s\n", pair.one, pair.two, pathstr); prop_funcs = (PropertyPair *) g_hash_table_lookup (path->properties, &pair); if (!prop_funcs) + { + DBusMessage *ret; #ifdef DBUS_ERROR_UNKNOWN_PROPERTY - return dbus_message_new_error (message, DBUS_ERROR_UNKNOWN_PROPERTY, "Property unavailable"); + ret = dbus_message_new_error (message, DBUS_ERROR_UNKNOWN_PROPERTY, "Property unavailable"); #else - return dbus_message_new_error (message, DBUS_ERROR_FAILED, "Property unavailable"); + ret = dbus_message_new_error (message, DBUS_ERROR_FAILED, "Property unavailable"); #endif + dbus_error_free (&error); + return ret; + } datum = path_get_datum (path, pathstr); if (!datum) |