diff options
| author | Thomas Haller <thaller@redhat.com> | 2020-04-08 12:41:32 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2020-04-08 12:41:32 +0200 |
| commit | 9a74d2e023007deceb808d8687acc561a195f0bb (patch) | |
| tree | 54b5c7f6bf11fadd40fcb2d8e2f3f9d29b78d0a2 | |
| parent | 88756703cf070e37fcfc5fc61a5c09b75de1de2c (diff) | |
| download | NetworkManager-9a74d2e023007deceb808d8687acc561a195f0bb.tar.gz | |
dns: add FIXME comment about adding default "~" routing search domain
| -rw-r--r-- | src/dns/nm-dns-manager.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/dns/nm-dns-manager.c b/src/dns/nm-dns-manager.c index a3c3a59c47..ac8a2afc41 100644 --- a/src/dns/nm-dns-manager.c +++ b/src/dns/nm-dns-manager.c @@ -1321,6 +1321,11 @@ rebuild_domain_lists (NMDnsManager *self) * If there is no default route, add the wildcard domain to all non-VPN * connections */ if (default_route_found) { + /* FIXME: this heuristic of which device has a default route does + * not work with policy routing (as used by default with WireGuard). + * We should have a more stable mechanism where an NMIPConfig indicates + * whether it is suitable for certain operations (like having an automatically + * added "~" domain). */ if (nm_ip_config_best_default_route_get (ip_config)) domains[num_dom1++] = "~"; } else { |