diff options
author | Thomas Haller <thaller@redhat.com> | 2019-05-23 09:10:07 +0200 |
---|---|---|
committer | Thomas Haller <thaller@redhat.com> | 2019-05-27 12:01:09 +0200 |
commit | 58704a37aed1b63bad68a85e93479d9d39f46448 (patch) | |
tree | 9933f5c08bbb428268aea44f638e240292a8a39e | |
parent | dd72696af77db85186e8454c3e4618d790ac159f (diff) | |
download | NetworkManager-58704a37aed1b63bad68a85e93479d9d39f46448.tar.gz |
dispatcher: don't print debug messages of dispatcher in regular mode
Previously, we would log several messages with level "debug" / g_info().
_LOG_R_D (request, "start running ordered scripts...");
_LOG_R_D (request, "new request (%u scripts)", request->scripts->len);
_LOG_R_D (request, "completed: no scripts");
Note that this effectively logs a message for every event. I think that
is to verbose and not suitable for regular logging.
Only enable these messages if debug logging is enabled. As such, these debug
level messsages now are enabled together with the trace level messages.
-rw-r--r-- | dispatcher/nm-dispatcher.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/dispatcher/nm-dispatcher.c b/dispatcher/nm-dispatcher.c index f1eb76bc61..4a36d225c5 100644 --- a/dispatcher/nm-dispatcher.c +++ b/dispatcher/nm-dispatcher.c @@ -169,17 +169,18 @@ struct Request { } G_STMT_END static gboolean -_LOG_R_T_enabled (const Request *request) +_LOG_R_D_enabled (const Request *request) { return request->debug; } +#define _LOG_R_T_enabled(request) _LOG_R_D_enabled (request) #define _LOG_R_T(_request, ...) _LOG(_request, NULL, FALSE, g_debug, __VA_ARGS__) -#define _LOG_R_D(_request, ...) _LOG(_request, NULL, TRUE, g_info, __VA_ARGS__) +#define _LOG_R_D(_request, ...) _LOG(_request, NULL, FALSE, g_info, __VA_ARGS__) #define _LOG_R_W(_request, ...) _LOG(_request, NULL, TRUE, g_warning, __VA_ARGS__) #define _LOG_S_T(_script, ...) _LOG(NULL, _script, FALSE, g_debug, __VA_ARGS__) -#define _LOG_S_D(_script, ...) _LOG(NULL, _script, TRUE, g_info, __VA_ARGS__) +#define _LOG_S_D(_script, ...) _LOG(NULL, _script, FALSE, g_info, __VA_ARGS__) #define _LOG_S_W(_script, ...) _LOG(NULL, _script, TRUE, g_warning, __VA_ARGS__) /*****************************************************************************/ |