diff options
| author | Thomas Haller <thaller@redhat.com> | 2023-03-01 08:22:03 +0100 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2023-03-29 11:46:48 +0200 |
| commit | 1ed385440214f7893d688286670a0f543272ea32 (patch) | |
| tree | 6f2318286f0d1355fa754a6199180ffddaf5a3bf | |
| parent | 37de834575bf1c8a69b96ff2647a394b855e693d (diff) | |
| download | NetworkManager-1ed385440214f7893d688286670a0f543272ea32.tar.gz | |
checkpatch: discourage deprecated "(allow-none)" annotation
| -rwxr-xr-x | contrib/scripts/checkpatch.pl | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/contrib/scripts/checkpatch.pl b/contrib/scripts/checkpatch.pl index 797caac847..c24db35e0e 100755 --- a/contrib/scripts/checkpatch.pl +++ b/contrib/scripts/checkpatch.pl @@ -191,6 +191,7 @@ complain ("Don't use space inside elvis operator ?:") if $line =~ /\?[\t ]+:/; complain ("Don't add Emacs editor formatting hints to source files") if $line_no == 1 and $line =~ /-\*-.+-\*-/; complain ("XXX marker are reserved for development while work-in-progress. Use TODO or FIXME comment instead?") if $line =~ /\bXXX\b/; complain ("This gtk-doc annotation looks wrong") if $line =~ /\*.*\( *(transfer-(none|container|full)|allow none) *\) *(:|\()/; +complain ("The gtk-doc annotation (allow-none) is deprecated. Use either (nullable) and/or (optional). See https://gi.readthedocs.io/en/latest/annotations/giannotations.html#deprecated-gobject-introspection-annotations") if $line =~ /\*.*\( *(allow-none) *\) *(:|\()/; complain ("Prefer nm_assert() or g_return*() to g_assert*()") if $line =~ /g_assert/ and (not $filename =~ /\/tests\//) and (not $filename =~ /\/nm-test-/); complain ("Use gs_free_error with GError variables") if $line =~ /\bgs_free\b +GError *\*/; complain ("Initialize GError variables to NULL, if you pass them on") if $line =~ /\bGError +\*([a-z0-9_]+);/; |