1 files changed, 42 insertions, 16 deletions

diff --git a/tests/DLL_Wrapper_Test.cpp b/tests/DLL_Wrapper_Test.cpp
index db4d9f92850..aeecf986f85 100644
--- a/tests/DLL_Wrapper_Test.cpp
+++ b/tests/DLL_Wrapper_Test.cpp
@@ -6,6 +6,8 @@
 //    tests
 //
 // = FILENAME
+// @@ Kirthika, please rename this test to be DLL_Test.cpp to be
+// consistent with out other naming conventions in this directory.
 //    DLL_Wrapper_Test.cpp
 //
 // = DESCRIPTION
@@ -20,54 +22,78 @@
 
 class Hello 
 {
+  // = TITLE
+  //   // @@ Kirthika, please fill in here.
+  //
+  // = DESCRIPTION
+  //   // @@ Kirthika, please fill in here.
 public:
 
-  Hello ()
-    {
-    }
+  Hello (void)
+    { }
 
-  ~Hello ()
-    {
-    }
+  ~Hello (void)
+    { }
 
-  void sayHello ()
+  // @@ Kirthika, please follow the ACE programming 
+  // guidelines when naming methods, i.e., say_hello (void) or just
+  // hello (void).
+  void sayHello (void)
     {
       ACE_DEBUG ((LM_DEBUG,
                   "Hello\t"));
     }
 
-  void sayNext ()
+  // @@ Same here.
+  void sayNext (void)
     {
       ACE_DEBUG ((LM_DEBUG,
                   "How are you?\n"));
     }
-  
 };
 
 // This function returns the Hello object pointer.
 
 extern "C"
-Hello* getHello (void)
+// @@ Kirthika, please following ACE programming guidelines to name
+// this function...
+Hello *getHello (void)
 {
   Hello *hello;
+  // @@ Kirthika, please always use ACE_NEW_RETURN for dynamic
+  // allocation.
   hello = new Hello;
   return hello;
 }
 
-typedef Hello* (*TC)(void);
+typedef Hello *(*TC)(void);
 
-int main (void)
+int 
+main (void)
 {
-  // First get an DLL object. Since the dllname is empty, the symbols 
-  // are loaded from a.out.
+  // @@ Kirthika, please follow the conventions for creating tests,
+  // i.e., use the ACE_START_TEST() and ACE_END_TEST() macros.
+
+  // @@ Kirthika, I suspect that the use of ACE_DL_TYPE (0) may not be
+  // portable across NT and UNIX.  Therefore, can you please use the
+  // name of the *.o file, i.e., ".shobj/DLL_Test.so" or whatevery it
+  // is?  Note that you'll need to figure out how to use various ACE
+  // macros to get this portable...  First get an DLL object. Since
+  // the dllname is empty, the symbols are loaded from a.out.
   ACE_DLL ace_dll_obj (ACE_DL_TYPE (0));
+
+  // @@ Kirthika, I'm not sure, but you may need to prefix a "_"
+  // before the "getHello" name, i.e., "_getHello" to make this work
+  // on some platforms.  Please use the ACE macros for portable here.
   TC f = (TC) ace_dll_obj.symbol ("getHello");
-  Hello* my_hello = f ();
+  Hello *my_hello = f ();
 
-  // Make the method calls, now that the object pointer is available.  
+  // Make the method calls, now that the object pointer is available.
   my_hello->sayHello ();
   my_hello->sayNext ();
 
+  // Please use an auto_ptr<> to make sure that my_hello is properly
+  // deleted when the scope of main() is exited.
   delete my_hello;
   return 0;
 }