Merge branch 'benbrown/fix-rpm-check' into 'master'

Fix rpm/rpmbuild error checking

See merge request baserock/ybd!402

1 files changed, 2 insertions, 2 deletions

diff --git a/ybd/rpm.py b/ybd/rpm.py
index 52d2f98..f7e29b6 100644
--- a/ybd/rpm.py
+++ b/ybd/rpm.py
@@ -567,9 +567,9 @@ def package_rpms(system, whitelist=None):
         env_vars = sandbox.env_vars_for_build(system)
         test_cmds = ['rpm --version', 'rpmbuild --version']
         for cmd in test_cmds:
-            error = sandbox.run_sandboxed(
+            success, _, _ = sandbox.run_sandboxed(
                 system, cmd, env_vars, exit_on_error=False)
-            if error:
+            if not success:
                 log('RPM-BUILD', 'To generate rpms, appropriate rpm and '
                     'rpmbuild binaries are required', exit=True)