diff options
| author | Alan Coopersmith <alan.coopersmith@oracle.com> | 2013-05-01 23:58:39 -0700 |
|---|---|---|
| committer | Alan Coopersmith <alan.coopersmith@oracle.com> | 2013-05-23 08:13:25 -0700 |
| commit | 59b8e1388a687f871831ac5a9e0ac11de75e2516 (patch) | |
| tree | d2da4d43b4914089efdde02ace9613b41a937427 /src/XListDProp.c | |
| parent | 5d43d4914dcabb6de69859567061e99300e56ef4 (diff) | |
| download | xorg-lib-libXi-59b8e1388a687f871831ac5a9e0ac11de75e2516.tar.gz | |
Use _XEatDataWords to avoid overflow of rep.length bit shifting
rep.length is a CARD32, so rep.length << 2 could overflow in 32-bit builds
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Diffstat (limited to 'src/XListDProp.c')
| -rw-r--r-- | src/XListDProp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/XListDProp.c b/src/XListDProp.c index 8667350..bde6cb5 100644 --- a/src/XListDProp.c +++ b/src/XListDProp.c @@ -65,7 +65,7 @@ XListDeviceProperties(Display* dpy, XDevice* dev, int *nprops_return) props = (Atom*)Xmalloc(rep.nAtoms * sizeof(Atom)); if (!props) { - _XEatData(dpy, rep.nAtoms << 2); + _XEatDataWords(dpy, rep.length); goto cleanup; } |