summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGaël Bonithon <gael@xfce.org>2022-03-17 00:01:15 +0100
committerGaël Bonithon <gael@xfce.org>2022-03-17 00:08:33 +0100
commitebaafc825af1c7fd11d3ebf37482ffe1ffc3bb69 (patch)
tree8649740c87ea7bad8659a7da33186bfdd781b784
parent86f9461d976a586f7a84876aba5249ea2468c904 (diff)
downloadtumbler-ebaafc825af1c7fd11d3ebf37482ffe1ffc3bb69.tar.gz
Fix missing mutex unlock in group scheduler
Tumbler could get stuck if a previous request was cancelled because of this. An obsolete assert is also removed which may prevent an error signal from being sent. Fixes #56.
-rw-r--r--tumblerd/tumbler-group-scheduler.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tumblerd/tumbler-group-scheduler.c b/tumblerd/tumbler-group-scheduler.c
index a266542..080213b 100644
--- a/tumblerd/tumbler-group-scheduler.c
+++ b/tumblerd/tumbler-group-scheduler.c
@@ -546,6 +546,7 @@ tumbler_group_scheduler_thread (gpointer data,
if (request->dequeued)
{
tumbler_group_scheduler_finish_request (scheduler, request);
+ tumbler_mutex_unlock (scheduler->mutex);
return;
}
tumbler_mutex_unlock (scheduler->mutex);
@@ -680,7 +681,6 @@ tumbler_group_scheduler_thumbnailer_error (TumblerThumbnailer *thumbnailer,
g_return_if_fail (TUMBLER_IS_THUMBNAILER (thumbnailer));
g_return_if_fail (failed_uri != NULL);
- g_return_if_fail (error_code < 0);
g_return_if_fail (uri_errors != NULL);
/* allocate a new URI error */