diff options
| author | Olaf Hering <olaf@aepfle.de> | 2023-05-12 12:26:14 +0000 |
|---|---|---|
| committer | Andrew Cooper <andrew.cooper3@citrix.com> | 2023-05-16 20:03:02 +0100 |
| commit | 42abf5b9c53eb1b1a902002fcda68708234152c3 (patch) | |
| tree | 5a598e5c5390580b6567e4fcdf5b2744ec1b9c9e /tools/libs | |
| parent | 9d628ff6cc2157c4e5293562caa1cd985b03fa20 (diff) | |
| download | xen-master.tar.gz | |
According to openpty(3) it is required to include <pty.h> to get the
prototypes for openpty() and login_tty(). But this is not what the
function AX_CHECK_PTYFUNCS actually does. It makes no attempt to include
the required header.
The two source files which call openpty() and login_tty() already contain
the conditionals to include the required header.
Remove the bogus m4 file to fix build with clang, which complains about
calls to undeclared functions.
Remove usage of INCLUDE_LIBUTIL_H in libxl_bootloader.c, it is already
covered by inclusion of libxl_osdep.h.
Remove usage of PTYFUNCS_LIBS in libxl/Makefile, it is already covered
by UTIL_LIBS from config/StdGNU.mk.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Diffstat (limited to 'tools/libs')
| -rw-r--r-- | tools/libs/light/Makefile | 2 | ||||
| -rw-r--r-- | tools/libs/light/libxl_bootloader.c | 4 |
2 files changed, 1 insertions, 5 deletions
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 96daeabc47..5d7ff94b05 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -158,7 +158,7 @@ NO_HEADERS_CHK := y include $(XEN_ROOT)/tools/libs/libs.mk -LDLIBS-y += $(PTYFUNCS_LIBS) +LDLIBS-y += $(UTIL_LIBS) LDLIBS-$(CONFIG_LIBNL) += $(LIBNL3_LIBS) LDLIBS-$(CONFIG_Linux) += -luuid LDLIBS-$(CONFIG_Linux) += -lrt diff --git a/tools/libs/light/libxl_bootloader.c b/tools/libs/light/libxl_bootloader.c index 18e9ebd714..1bc6e51827 100644 --- a/tools/libs/light/libxl_bootloader.c +++ b/tools/libs/light/libxl_bootloader.c @@ -19,10 +19,6 @@ #include <utmp.h> #endif -#ifdef INCLUDE_LIBUTIL_H -#include INCLUDE_LIBUTIL_H -#endif - #include "libxl_internal.h" #define BOOTLOADER_BUF_OUT 65536 |