summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Add tests for unix socket parsingHEADmasterDemi Marie Obenour2023-03-252-5/+45
| | | | Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
* DISPLAY starting with / or unix: is always a socket pathDemi Marie Obenour2023-03-251-50/+59
| | | | | | | | | | If DISPLAY starts with / or unix:, do not check for anything but a full filesystem socket path. In particular, abstract AF_UNIX sockets and TCP sockets will not be used in this case. Also be stricter about parsing the screen part of /path.screen displays, and bail out after all stat() errors other than ENOENT. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
* Allow full paths to sockets on non-macOSDemi Marie Obenour2023-03-252-23/+9
| | | | | | | | | | | When combined with xorg/lib/libxtrans!7, this allows CVE-2020-25697 to be mitigated by placing the AF_UNIX socket in a secure directory on the filesystem. This enables HAVE_LAUNCHD unconditionally and deletes the configure switch. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
* Fix xcb_connect() call with a custom xcb_auth_info_tMatthieu Herrb2023-02-281-3/+1
| | | | | | | | | | If the function implementing xcb_connect is called directly with a custom xcb_auth_info_t then checking that the screen in $DISPLAY is valid is skipped. Reported by chohag AT jtan DOT com Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
* configure.ac: drop `pthread-stubs` dependency on DragonFly and FreeBSDJan Beich2023-02-111-1/+1
| | | | | All `pthread_*` symbols used by libxcb have stubs in libc. So, stop linking against libpthread.
* Raise minimum required version of Python from 2.6 to 3.0Alan Coopersmith2023-02-091-1/+1
| | | | | | | | | | | Trying to build with Python 2.7.14 fails with: File "./c_client.py", line 2270 key = (*self.name[:-1], field.enum) ^ SyntaxError: invalid syntax Fixes: 33f3dbe ("Fix handling of documented enum parameters") Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* configure.ac: Remove obsolete AC_HEADER_STDCAlan Coopersmith2023-02-061-1/+0
| | | | | | | | | | | | | Nothing checks for the STDC_HEADERS flag this set, and all supported systems have C89 compatible headers now. Clears autoconf warnings of: configure.ac:93: warning: The macro `AC_HEADER_STDC' is obsolete. configure.ac:93: You should run autoupdate. ./lib/autoconf/headers.m4:704: AC_HEADER_STDC is expanded from... configure.ac:93: the top level Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Fix indentation.Daniel G2023-01-091-2/+2
|
* Fix windows build.Daniel G2023-01-071-1/+5
|
* xcb_conn: Add a check for NULL to silence a UBSan runtime errorJeremy Huddleston Sequoia2022-11-261-3/+5
| | | | | | xcb_conn.c:314:60: runtime error: applying zero offset to null pointer Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
* Fix handling of documented enum parametersDemi Marie Obenour2022-10-161-4/+5
| | | | | | Previously this would crash the code generator. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
* Fix a compiler warningDemi Marie Obenour2022-10-161-2/+2
| | | | | | The warning is harmless but annoying. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
* configure.ac: drop dependency `pthread-stubs` on SolarisAlan Coopersmith2022-10-041-1/+1
| | | | | | | | | | | On Solaris 10 and later, the pthread functions are directly in libc, and libpthread only has metadata to redirect calls from it to the libc functions. On Solaris 9 and older (no longer supported), libc contained its own thread stubs that libpthread then overrode. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* configure.ac: drop dependency `pthread-stubs` on macOSPaperChalice2022-09-281-1/+1
| | | | | `libpthread.dylib` on macOS is an alias of `libSystem.B.dylib`, every program should link against `libSystem.B.dylib`.
* Improve tutorial exampleUli Schlachter2022-09-281-3/+1
| | | | | | | | | | | | | | | | This tutorial example only handles XCB_EXPOSURE and XCB_KEY_RELEASE events and ignores everything else. Thus, there is no point in asking for more kinds of events. A while ago, I ported this tutorial to x11rb [1]. Recently, I received a pull request [2] removing these unnecessary event masks. This commit is thus only partially by me and the 'issue' was originally found by the author of [2]. [1]: https://github.com/psychon/x11rb/blob/master/x11rb/examples/tutorial.rs [2]: https://github.com/psychon/x11rb/pull/754 Signed-off-by: Uli Schlachter <psychon@znc.in>
* autogen: add default patch prefixMihail Konev2022-07-241-0/+3
| | | | | Signed-off-by: Mihail Konev <k.mvc@ya.ru> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* autogen.sh: use quoted string variablesEmil Velikov2022-07-241-4/+4
| | | | | | | | | | Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* autogen.sh: use exec instead of waiting for configure to finishPeter Hutterer2022-07-241-1/+1
| | | | | | | | Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Emil Velikov <emil.velikov@collabora.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* gitlab CI: add a basic build testAlan Coopersmith2022-07-181-0/+98
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Require xcb-proto >= 1.15.1, which has DbeMike Sharov2022-06-221-1/+1
| | | | Signed-off-by: Mike Sharov <msharov@users.sourceforge.net>
* Build DOUBLE-BUFFER extension.Mike Sharov2022-06-025-0/+26
| | | | Signed-off-by: Mike Sharov <msharov@users.sourceforge.net>
* libxcb 1.15libxcb-1.15Matt Turner2022-05-031-1/+1
| | | | Signed-off-by: Matt Turner <mattst88@gmail.com>
* Fix a memory leakHodong2022-01-151-1/+2
| | | | Signed-off-by: Hodong <hodong@yozmos.com>
* Fix integer overflows in xcb_in.cDemi Marie Obenour2021-11-171-3/+9
| | | | | This fixes an integer overflow security vulnerability in xcb_in.c, which may allow for memory corruption.
* Fix hang in xcb_request_check()Thomas Anderson2021-09-303-4/+12
| | | | | | | | | This fixes https://gitlab.freedesktop.org/xorg/lib/libxcb/-/issues/53 The issue was that libxcb expected to get a reply based on the request_expected variable, but a reply would never arrive because the request was never actually written. To resolve this, a separate request_expected_written variable is added.
* Avoid request counter truncation in replies map after 2**32 requestsRan Benita2021-09-302-5/+5
| | | | | | | | | | | | | | | The c->in request counters are uint64_t, and can realistically go over 2**32 over a lifetime of a client. The c->in->replies map however uses unsigned int keys and the passed request numbers are silently truncated. I haven't analyzed in depth what happens what it wraps around but it's probably nothing good. The only user of the xcb_list.c map code is c->in->replies, so just change it to use uint64_t keys. Reviewed-by: Uli Schlachter <psychon@znc.in> Signed-off-by: Ran Benita <ran@unusedvar.com>
* Add newline when printing auth/connection failure string to stderrJulien Cristau2021-09-301-0/+4
| | | | | | | | | | The reason strings returned by the server don't all include a newline, so make sure we add one to avoid confusing clients. Xlib used to do this before it delegated that work to libxcb. Fixes #34 Signed-off-by: Julien Cristau <jcristau@debian.org>
* Improve/fix docs for reply fds functionsUli Schlachter2021-09-201-2/+3
| | | | | Fixes: https://gitlab.freedesktop.org/xorg/lib/libxcb/-/issues/56 Signed-off-by: Uli Schlachter <psychon@znc.in>
* c_client.py: Implement handling of <length> elementPovilas Kanapickas2021-07-301-0/+10
| | | | Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
* c_client: Extract _c_get_field_mapping_for_expr()Povilas Kanapickas2021-07-301-7/+19
|
* c_client.py: Use get_expr_field_names directly to resolve list fieldsPovilas Kanapickas2021-07-301-1/+1
| | | | | | | | | | | Using get_expr_fields() is only needed in case we are doing things that can span multiple types easily, e.g. when deciding what data to pass via function parameters and so on. In _c_serialize_helper_list_field() we are building function body, so acquiring field names via get_expr_field_names() is enough. Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
* c_client.py: Extract get_expr_field_names()Povilas Kanapickas2021-07-301-29/+32
| | | | Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
* Fix writev emulation on WindowsPeter Harris2021-06-041-21/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are at least two bugs in the previous implementation: - If an early iovec is partially written, there can be a gap of missing data (as a later iovec will be started before the early iovec is completed). - If a late iovec returns WSAEWOULDBLOCK, *vector and *count are not updated, leading to a re-send of the entire request. Move the *vector update into the send() loop to update piecemeal as individual iovecs are sent. Example program that demonstrates the issue (this program should run forever after these bugs have been fixed): #include <stdio.h> #include <stdlib.h> #include "xcb.h" // Non-cryptographic random number generator from http://burtleburtle.net/bob/rand/smallprng.html // because Microsoft's random number generators either have a too small RAND_MAX or are too slow typedef struct ranctx { uint32_t a; uint32_t b; uint32_t c; uint32_t d; } ranctx; static uint32_t ranval(ranctx *x); static void raninit(ranctx *x, uint32_t seed); #define MAX_PROP_LEN (128 * 1024) int main(int argc, char *argv[]) { uint32_t seed = 0x12345678; if (argc > 1) { seed = strtoul(argv[1], NULL, 0); } ranctx ran; raninit(&ran, seed); xcb_connection_t *c = xcb_connect(NULL, NULL); if (!c || xcb_connection_has_error(c)) { printf("Cannot connect to $DISPLAY\n"); return 1; } const xcb_setup_t *setup = xcb_get_setup(c); char *buf = malloc(MAX_PROP_LEN + 8); // plus a bit of slack so we can run random values off the end if (!buf) { printf("oom\n"); return 1; } for (uint32_t i=0; i < (MAX_PROP_LEN + 3) / 4; i++) { ((uint32_t *)buf)[i] = ranval(&ran); } xcb_window_t win = xcb_generate_id(c); xcb_create_window(c, 0, win, xcb_setup_roots_iterator(setup).data[0].root, 0, 0, 1, 1, 0, XCB_WINDOW_CLASS_INPUT_ONLY, 0, 0, NULL); printf("Created window 0x%X\n", win); for (;;) { xcb_flush(c); xcb_generic_event_t *ev = xcb_poll_for_event(c); if (ev) { if (ev->response_type == 0) { xcb_generic_error_t *err = (xcb_generic_error_t *)ev; printf("Unexpected X Error %d\n", err->error_code); printf(" Sequence %d\n", err->sequence); printf(" Resource ID 0x%X\n", err->resource_id); printf(" Opcode: %d.%d\n", err->major_code, err->minor_code); return 1; } printf("Unexpected X Event %d\n", ev->response_type); return 1; } uint32_t siz = ranval(&ran) % MAX_PROP_LEN + 1; xcb_change_property(c, XCB_PROP_MODE_REPLACE, win, XCB_ATOM_STRING, XCB_ATOM_STRING, 8, siz, buf); } return 0; } #define rot(x,k) (((x)<<(k))|((x)>>(32-(k)))) static uint32_t ranval(ranctx *x) { uint32_t e = x->a - rot(x->b, 27); x->a = x->b ^ rot(x->c, 17); x->b = x->c + x->d; x->c = x->d + e; x->d = e + x->a; return x->d; } static void raninit(ranctx *x, uint32_t seed) { uint32_t i; x->a = 0xf1ea5eed, x->b = x->c = x->d = seed; for (i = 0; i<20; ++i) { (void)ranval(x); } } Signed-off-by: Peter Harris <pharris@opentext.com>
* Fix build on WindowsPeter Harris2021-06-046-6/+34
| | | | | | | | | Notable changes: Protect include of unistd.h (and other POSIX headers). Use SOCKET (which is larger than int) and closesocket (because close is not compatible) for sockets. Use <stdint.h>'s intptr_t instead of the non-portable ssize_t. Signed-off-by: Peter Harris <pharris@opentext.com>
* xcb_auth: Quiet -Wimplicit-fallthrough warning in get_authptr()Alan Coopersmith2021-06-012-0/+11
| | | | | | | | | | | xcb_auth.c:135:14: warning: this statement may fall through [-Wimplicit-fallthrough=] addr += 12; ~~~~~^~~~~ xcb_auth.c:138:5: note: here case AF_INET: ^~~~ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Increment libtool version info for libxcb-dri3Julien Cristau2021-02-021-1/+1
| | | | | | | | | | | | | | | | | | Somewhat belatedly given the last update was in xcb-proto 1.13 in 2017... Quoting @smcv from https://bugs.debian.org/921069: >>> libxcb-dri3 version 1.13 appears to have added new symbols without increasing the minor ABI version in its -version-info. This will break anything that compares libraries by their version info to decide which one is newer. The Steam Runtime uses libraries' major/minor/micro ABI version info (in this case 0.0.0) to decide whether to use the system copy of a library or the copy in the Steam Runtime, depending on which one is newer (#921026). We can work around this by adding a versioned dependency on libxcb-dri3-0 and deleting the copy from the Steam Runtime, but this isn't a particularly scalable solution. >>>
* gitignore: add files generated by make checkRan Benita2020-11-181-0/+3
| | | | Signed-off-by: Ran Benita <ran@unusedvar.com>
* tests: don't use deprecated fail_unless check APIRan Benita2020-11-182-16/+16
| | | | | | | | | | | It causes errors like this when running make check: check_public.c:40:24: error: too many arguments for format [-Werror=format-extra-args] 40 | fail_unless(success, "unexpected parse failure %sfor '%s'", test_string[test_type], name); Closes: https://gitlab.freedesktop.org/xorg/lib/libxcb/-/issues/49 Tested-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Ran Benita <ran@unusedvar.com>
* Use the 'present' field to properly check that the XC-MISCEduardo Sánchez Muñoz2020-03-022-2/+2
| | | | | | extension is available in xcb_generate_id. Also document the returned value when xcb_generate_id fails.
* Release libxcb 1.14libxcb-1.14Matt Turner2020-02-222-2/+9
| | | | Signed-off-by: Matt Turner <mattst88@gmail.com>
* Build xz tarballs instead of bzip2Matt Turner2020-02-221-1/+1
| | | | Signed-off-by: Matt Turner <mattst88@gmail.com>
* configure.ac: Depend on pthread-stubs only on not-LinuxMatt Turner2020-02-221-1/+5
| | | | Signed-off-by: Matt Turner <mattst88@gmail.com>
* Implement xcb_total_read() and xcb_total_written().Sam Varshavchik2020-02-224-0/+60
| | | | | | | | | | | Returns raw byte counts that have been read or written to the xcb_connection_t. I found it very useful when developing a high level widget toolkit, to track down inefficient/sub-optimum code that generates a lot of X protocol traffic. Signed-off-by: Sam Varshavchik <mrsam@courier-mta.com>
* tests: Support Check 0.13.0 APIA. Wilcox2020-02-222-0/+13
| | | | | | [mattst88]: Keep compatibility with old API via preprocessor Fixes: #43
* Handle EINTR from recvmsg in _xcb_in_readMartin Dørum2019-05-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I have a GTK application which occasionally crashes with an "interrupted system call" g_message from gdk. After a lot of debugging, I've found that the call to recvmsg in _xcb_in_read occasionally fails with EINTR, and instead of retrying the system call, xcb would just shut down the connection. This change makes _xcb_in_read treat EINTR the same as it would treat EAGAIN; it returns 1 and libX11 ends up calling xcb_poll_for_event again (from what I have understood). I have spoken with a few people who think recvmsg failing with EINTR in this case shouldn't ever happen, and I don't know enough to agree or disagree with that. In case anyone wants to dig further and try to figure out why the recvmsg call sometimes fails with EINTR, here's the backtrace from inside of _xcb_in_read where that happened: Thread 1 "beanbar" hit Breakpoint 1, _xcb_in_read (c=c@entry=0x55ecbe4aba80) at xcb_in.c:1059 1059 fprintf(stderr, "Hello World am %s:%i, errno is %s\n", __FILE__, __LINE__, strerror(errno)); (gdb) bt 0 0x00007fa48fa48639 in _xcb_in_read (c=c@entry=0x55ecbe4aba80) at xcb_in.c:1059 1 0x00007fa48fa489d8 in poll_for_next_event (c=0x55ecbe4aba80, queued=queued@entry=0) at xcb_in.c:352 2 0x00007fa48fa48a3d in poll_for_next_event (queued=0, c=<optimized out>) at xcb_in.c:722 3 0x00007fa48fa48a3d in xcb_poll_for_event (c=<optimized out>) at xcb_in.c:722 4 0x00007fa4908d1b7e in poll_for_event (dpy=dpy@entry=0x55ecbe4a9730, queued_only=queued_only@entry=0) at xcb_io.c:245 5 0x00007fa4908d1cf0 in poll_for_response (dpy=dpy@entry=0x55ecbe4a9730) at xcb_io.c:303 6 0x00007fa4908d1fed in _XEventsQueued (mode=2, dpy=0x55ecbe4a9730) at xcb_io.c:363 7 0x00007fa4908d1fed in _XEventsQueued (dpy=dpy@entry=0x55ecbe4a9730, mode=mode@entry=2) at xcb_io.c:344 8 0x00007fa4908c3d47 in XPending (dpy=0x55ecbe4a9730) at Pending.c:55 9 0x00007fa493cadbc7 in () at /usr/lib/libgdk-3.so.0 10 0x00007fa49234d08a in g_main_context_prepare () at /usr/lib/libglib-2.0.so.0 11 0x00007fa49234d6e6 in () at /usr/lib/libglib-2.0.so.0 12 0x00007fa49234d8ae in g_main_context_iteration () at /usr/lib/libglib-2.0.so.0 13 0x00007fa4938b920e in g_application_run () at /usr/lib/libgio-2.0.so.0 14 0x000055ecbc820af4 in main (argc=1, argv=0x7ffd06238098) at src/main.c:190 Signed-off-by: Martin Dørum <martid0311@gmail.com>
* Include time.h before using time()Jon Turney2019-04-251-0/+1
| | | | Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
* Add README.md to EXTRA_DISTAlan Coopersmith2019-02-171-0/+1
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Add "ge.*" to src/.gitignoreEduardo Sánchez Muñoz2019-02-171-0/+1
|
* Update README for gitlab migrationAlan Coopersmith2019-02-161-12/+17
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
* Update configure.ac bug URL for gitlab migrationAlan Coopersmith2019-02-161-1/+1
| | | | Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
View Lorry Controller Status