summaryrefslogtreecommitdiff
path: root/ivi-shell
diff options
context:
space:
mode:
authorPekka Paalanen <pekka.paalanen@collabora.com>2019-11-06 12:07:23 +0200
committerDaniel Stone <daniel@fooishbar.org>2019-11-21 16:32:55 +0000
commitd2b9b5d1ccff5934f2c75ca2dad64d6ff8f4f790 (patch)
treefca501064bbe39ed615cfec7e46c2e7bdc5f673f /ivi-shell
parente5e8188aa5925c07d001efa58ce3ac25ed5458ec (diff)
downloadweston-d2b9b5d1ccff5934f2c75ca2dad64d6ff8f4f790.tar.gz
ivi-shell: fix init error path
This was forgetting to remove the compositor destroy listener if init failed, which would lead to use-after-free on compositor tear-down. Found by inspection. Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
Diffstat (limited to 'ivi-shell')
-rw-r--r--ivi-shell/ivi-shell.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c
index 244290b8..99431d0b 100644
--- a/ivi-shell/ivi-shell.c
+++ b/ivi-shell/ivi-shell.c
@@ -649,6 +649,7 @@ err_desktop:
weston_desktop_destroy(shell->desktop);
err_shell:
+ wl_list_remove(&shell->destroy_listener.link);
free(shell);
return IVI_FAILED;