summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* git: add a git publish configuration fileDaniel P. Berrangé2018-04-301-0/+4
| | | | | | | Provide a config file for git-publish that sets the right mailing list and patch subject prefix. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
* cli: remove unused --spice-disable-auto-usbredir argDaniel P. Berrangé2018-04-301-2/+0
| | | | | | | | | | | | This functionality was removed in: commit c9b2ec163f15f41fe5010b7b1c215f6c204d93a6 Author: Cole Robinson <crobinso@redhat.com> Date: Fri Mar 16 14:38:22 2018 -0400 preferences: Add UI for disabling spice usb autoredir Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
* uitests: Use old Fedora URL in test suiteCole Robinson2018-04-261-3/+3
| | | | | the centos URL is currently broken with latest urldetect, we need to add some info to libosinfo to cover it
* addhardware: Remove largely redundant validate() error handlingCole Robinson2018-04-251-130/+69
| | | | Just centralize it in one place. Clean up conn usage in some places
* addhardware: Make combo init/populating more consistentCole Robinson2018-04-255-598/+446
| | | | | | * Use the _build_combo helper more * Un-static methods that don't need it * Use pretty labels more
* addhardware: Remove non-spicevmc USB redir configCole Robinson2018-04-242-86/+7
| | | | | This is very rarely used, if at all, so it doesn't need to be in the UI
* graphics: Default to unset keymapCole Robinson2018-04-246-20/+10
| | | | | qemu and all related hypervisors (xen, vz) haven't needed this in the common case for a very long time, so make keymap=None the default
* cli: Fix --boot smbios_mode=sysinfo (bz 1570549)Cole Robinson2018-04-243-6/+3
| | | | | Not sure how this was expected to work, just make it do the simple thing and set the value in the XML. Add a test case for it
* urlfetcher: Add support for FTP authenticationMark Hamzy2018-04-241-1/+3
| | | | | | | If --location is an ftp url with a username and password then virt-install fails to install with an error: ERROR Error validating install location: Opening URL u failed: 530 Login incorrect..
* tests: uriparse: Test for @ symbol in usernameRadostin Stoyanov2018-04-241-0/+4
| | | | | | Add test case for URI that contains the @ symbol in username. Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
* urldetect: suse tumbleweed now has .treeinfo fileCole Robinson2018-04-241-1/+29
|
* urldetect: don't overwrite self.arch with suse content archCole Robinson2018-04-241-11/+11
| | | | They are different, so label it as tree_arch
* urldetect: Split out treeinfo logic from GenericTreeInfoCole Robinson2018-04-241-33/+59
| | | | | | SUSE distros will be growing treeinfo support soon and trying to handle this logic through class inheritance is difficult, so separate the logic into its own function
* urldetect: Drop a bunch of RH version integer handlingCole Robinson2018-04-241-30/+25
| | | | It's not really required
* urldetect: Standardize _detect_version namingCole Robinson2018-04-242-47/+33
| | | | This is the hook that subclasses use to save a detect os_variant value
* urldetect: Clean up opensuse variant detectionCole Robinson2018-04-241-21/+23
| | | | Make the logic easier to follow
* urldetect: Drop unused uses_treeinfoCole Robinson2018-04-241-2/+0
|
* test_urls: Improve error outputCole Robinson2018-04-241-8/+8
|
* Fix URI parsing when username contains @ signEduardo Kienetz2018-04-171-3/+4
| | | | | | | | | | On a domain-joined host the URI wasn't getting properly parsed due to the username containing an @ sign. Before: DEBUG (sshtunnels:263) ['ssh', 'ssh', '-l', 'eduardok', 'ad.mydomain.com@kvmhost1', 'sh -c', '\'nc -q 2>&1 | grep "requires an argument" >/dev/null;if [ $? -eq 0 ] ; then CMD="nc -q 0 127.0.0.1 5900";else CMD="nc 127.0.0.1 5900";fi;eval "$CMD";\''] After: DEBUG (sshtunnels:263) ['ssh', 'ssh', '-l', 'eduardok@ad.mydomain.com', 'kvmhost1', 'sh -c', '\'nc -q 2>&1 | grep "requires an argument" >/dev/null;if [ $? -eq 0 ] ; then CMD="nc -q 0 127.0.0.1 5900";else CMD="nc 127.0.0.1 5900";fi;eval "$CMD";\'']
* tests: urls: Fix custom ini file usageCole Robinson2018-04-161-1/+1
|
* setup: Install files in new virtinst foldersLuca Weiss2018-04-121-0/+2
| | | | | | In commits fe9ed23 and 3909c10 several files were moved to subfolder of virtinst, but they are not covered by the existing glob in the setup.py file. Fix that by adding those subfolders explicitely.
* man: virt-xml: Note --update implies --defineDavid H. Gutteridge2018-04-061-0/+2
|
* Fix copyright header to specify GPLv2 or later, not GPLv2 only.Daniel P. Berrangé2018-04-04166-166/+166
| | | | | | | | | | | | | | | | | | | | | | The copyright headers in every file were chjanged in this previous commit commit b6dcee8eb7ec4de999058c187162fe4aedef36b4 Author: Cole Robinson <crobinso@redhat.com> Date: Tue Mar 20 15:00:02 2018 -0400 Use consistent and minimal license header for every file Where before this they said " "either version 2 of the License, or (at your option) any later version." Now they just say "GNU GPLv2" This fixes it to say "GNU GPLv2 or later" again. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
* avoid referencing ConnectError if it is NoneDaniel P. Berrangé2018-04-041-2/+3
| | | | | | | | | | | | | | | Currently it throws an exception at startup which is hidden unless you run with --no-fork $ python3 ./virt-manager --no-fork Traceback (most recent call last): File "/home/berrange/src/virt/virt-manager/virtManager/baseclass.py", line 225, in wrap_func return func(*wrapargs) File "/home/berrange/src/virt/virt-manager/virtManager/engine.py", line 206, in conn_open_completed ConnectError.details) AttributeError: 'NoneType' object has no attribute 'details' Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
* virtinst: Trivial spelling fixCharles Arnold2018-04-041-1/+1
| | | | | | Trivial spelling fix. Signed-off-by: Charles Arnold <carnold@suse.com>
* urldetect: Remove some unused SUSE bitsCole Robinson2018-04-041-17/+7
| | | | | Charles confirmed for me that SUMMARY and arch fallback handling doesn't have any still relevant uses, so we can drop them
* baseclass: Catch another cursor failure instanceCole Robinson2018-04-031-14/+15
|
* tests: test_urls: Look for manual.ini in ~/.config/virt-managerCole Robinson2018-04-033-5/+2
| | | | Rather than deal with ignoring it in the source tree
* Bump devel version to 1.6.0Cole Robinson2018-04-031-1/+1
|
* spec: Move regular deps before big comment stringsCole Robinson2018-04-031-4/+2
|
* spec: Fix build on fedora 28Cole Robinson2018-04-031-0/+4
|
* baseclass: Catch cursor error if icon missing (bz 1516588)Cole Robinson2018-04-031-2/+9
| | | | | | | Debian users who installed virt-manager on a bare system found that a missing cursor icon theme caused addhardware wizard to fail https://bugzilla.redhat.com/show_bug.cgi?id=1516588
* tests: clitest: test virt-xml --update on inactive VMCole Robinson2018-04-032-0/+7
|
* virt-xml: Warn when --update is inapplicableDavid H. Gutteridge2018-04-031-3/+7
|
* urlfetcher: Simplify urllib importCole Robinson2018-04-031-2/+1
|
* domcapabilities: Document class layout a bitCole Robinson2018-04-031-0/+31
| | | | | It's a bit weird due to the repetitive nature of domainCapabilities XML layout
* tests: Remove __main__ handling, not neededCole Robinson2018-04-035-18/+0
|
* virtinst: compare host and domain cpu modelsCharles Arnold2018-04-032-7/+29
| | | | | | | | | Lookup the domain capabilities CPU model and compare with the host capabilities CPU model and if they are not equal set the guest's CPU model to None. (crobinso: compare against 'custom' list not 'host-model', move to separate function)
* virtinst: read CPU model from domain capabilitiesCharles Arnold2018-04-033-5/+121
| | | | | | | | Add functionality to acquire the CPU model from the libvirt domain capabilities. This is used to compare with the host CPU model. (crobinso: add test coverage, rework domcaps layout a bit)
* urldetect: Track SUSE regexs in their Distro classesCole Robinson2018-04-021-18/+21
|
* urldetect: Move SUSE content file handling into its own classCole Robinson2018-04-021-112/+130
| | | | | Try to untangle the interdependencies and not recalculate everything for every suse distro
* urldetect: Drop RedHatDistro baseclassCole Robinson2018-04-021-20/+16
| | | | | Just fold the minimal logic into GenericTreeinfo, since only RH distros use treeinfo so it's basically the same thing
* tests: test_urls: Add urldetect kernel arg validationCole Robinson2018-04-023-16/+32
|
* urldetect: Clean up Fedora version checking a bitCole Robinson2018-04-022-30/+26
|
* tests: test_urls: Enable f28 development testCole Robinson2018-03-291-3/+3
|
* tests: test_urls: Use https for debian-dailyCole Robinson2018-03-291-1/+1
| | | | It converts to http to https but that takes time, so fix it
* urlfetch: Formalize the failed hostname checkCole Robinson2018-03-293-7/+32
| | | | | This heuristic is only valid for http connections, everything else will fail way earlier in the process
* urlfetcher: Use persistent HTTP sessionCole Robinson2018-03-291-2/+15
| | | | | This shaves 20 seconds off the URL test suite, so probably helps regular users too :)
* urlfetcher: Clean up RHEL version parsing/handlingCole Robinson2018-03-293-78/+38
| | | | | Drop SLDistro entirely because it adds nothing, just make it an alias of Centos. Drop some old RHEL version logic. Tweak test cases
* urlfetch: Add caching layerCole Robinson2018-03-291-182/+180
| | | | | | | | Add an external caching layer that handles tracking all data we need as part of distro URL detection that is also needed during distro __init__. This way we can make is_valid() static and quick, and move all the variant hackery cleary into __init__ routines. This makes the code logic much easier to follow
View Lorry Controller Status