summaryrefslogtreecommitdiff
path: root/virtinst
diff options
context:
space:
mode:
authorCole Robinson <crobinso@redhat.com>2022-02-16 14:02:58 -0500
committerCole Robinson <crobinso@redhat.com>2022-02-16 14:02:58 -0500
commite37e27bc358ffc48b645eb94a39b515d7ebe8754 (patch)
tree5431c78a2a9d278543ca6d8677f3b1cd0ad25a2f /virtinst
parentd488472837745aa3b952bf777a6c54b58dbb3cee (diff)
downloadvirt-manager-e37e27bc358ffc48b645eb94a39b515d7ebe8754.tar.gz
guest: Rename _add_implied_controllers -> _add_virtioscsi_controller
Since that's all it does. And clean up the style a bit Signed-off-by: Cole Robinson <crobinso@redhat.com>
Diffstat (limited to 'virtinst')
-rw-r--r--virtinst/guest.py24
1 files changed, 12 insertions, 12 deletions
diff --git a/virtinst/guest.py b/virtinst/guest.py
index 5e810856..350de6dd 100644
--- a/virtinst/guest.py
+++ b/virtinst/guest.py
@@ -714,7 +714,7 @@ class Guest(XMLBuilder):
for dev in self.devices.get_all():
dev.set_defaults(self)
- self._add_implied_controllers()
+ self._add_virtioscsi_controller()
self._add_spice_devices()
def add_extra_drivers(self, extra_drivers):
@@ -986,17 +986,17 @@ class Guest(XMLBuilder):
dev.model = "virtio"
self.add_device(dev)
- def _add_implied_controllers(self):
- # Add virtio-scsi controller if needed
- if self.can_default_virtioscsi():
- for dev in self.devices.disk:
- if dev.bus == "scsi":
- ctrl = DeviceController(self.conn)
- ctrl.type = "scsi"
- ctrl.model = "virtio-scsi"
- ctrl.set_defaults(self)
- self.add_device(ctrl)
- break
+ def _add_virtioscsi_controller(self):
+ if not self.can_default_virtioscsi():
+ return
+ if not any([d for d in self.devices.disk if d.bus == "scsi"]):
+ return
+
+ ctrl = DeviceController(self.conn)
+ ctrl.type = "scsi"
+ ctrl.model = "virtio-scsi"
+ ctrl.set_defaults(self)
+ self.add_device(ctrl)
def _add_spice_channels(self):
if self.skip_default_channel: