devices: filesystem: Fix default virtiofs accessmode

We shouldn't use accessmode=mapped here, libvirt rejects it.
Let libvirt fill in a working default

Signed-off-by: Cole Robinson <crobinso@redhat.com>

1 files changed, 18 insertions, 10 deletions

diff --git a/virtinst/devices/filesystem.py b/virtinst/devices/filesystem.py
index a578a51e..fdf7d41a 100644
--- a/virtinst/devices/filesystem.py
+++ b/virtinst/devices/filesystem.py
@@ -135,14 +135,22 @@ class DeviceFilesystem(Device):
     def set_defaults(self, guest):
         ignore = guest
 
-        if self.conn.is_qemu() or self.conn.is_lxc() or self.conn.is_test():
-            # type=mount is the libvirt default. But hardcode it
-            # here since we need it for the accessmode check
-            if self.type is None:
-                self.type = self.TYPE_MOUNT
-
-            # libvirt qemu defaults to accessmode=passthrough, but that
-            # really only works well for qemu running as root, which is
-            # not the common case. so use mode=mapped
-            if self.accessmode is None:
+        if not (self.conn.is_qemu() or
+                self.conn.is_lxc() or
+                self.conn.is_test()):
+            return
+
+        # type=mount is the libvirt default. But hardcode it since other
+        # bits like validation depend on it
+        if self.type is None:
+            self.type = self.TYPE_MOUNT
+
+        if self.accessmode is None:
+            if self.driver_type == "virtiofs":
+                # let libvirt fill in default accessmode=passthrough
+                pass
+            else:
+                # libvirt qemu defaults to accessmode=passthrough, but that
+                # really only works well for qemu running as root, which is
+                # not the common case. so use mode=mapped
                 self.accessmode = self.MODE_MAPPED