diff options
| author | Cole Robinson <crobinso@redhat.com> | 2022-02-11 14:11:44 -0500 |
|---|---|---|
| committer | Cole Robinson <crobinso@redhat.com> | 2022-02-12 11:53:09 -0500 |
| commit | 3e794d2d96b85d5f0fe40183f21fcad2cf674b74 (patch) | |
| tree | 0247f695a732f7c5e661f61c7c78fcd118aa4743 /virtinst | |
| parent | 1f8afc8668dfb75f54a4008825b83c1d82151565 (diff) | |
| download | virt-manager-3e794d2d96b85d5f0fe40183f21fcad2cf674b74.tar.gz | |
virt-install: Turn --os-type into a no op and warning
I'm still seeing blog posts that recommend using
--os-type linux --os-variant XXX
Which has been a no op for a long time but is mostly harmless.
Current git would make this an error condition, but that's too
disruptive IMO. Just print a warning
Signed-off-by: Cole Robinson <crobinso@redhat.com>
Diffstat (limited to 'virtinst')
| -rw-r--r-- | virtinst/virtinstall.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/virtinst/virtinstall.py b/virtinst/virtinstall.py index 38da099c..5322d181 100644 --- a/virtinst/virtinstall.py +++ b/virtinst/virtinstall.py @@ -143,8 +143,10 @@ def convert_old_disks(options): def convert_old_os_options(options): - if not options.os_variant and options.old_os_type: - options.os_variant = options.old_os_type + if not options.old_os_type: + return + log.warning( + _("--os-type is deprecated and does nothing. Please stop using it.")) del(options.old_os_type) |