xmlutil: Centralize all 'programming error' exceptions

Raise them directly instead of adding the hard to read conditional
into the function

Signed-off-by: Cole Robinson <crobinso@redhat.com>

1 files changed, 5 insertions, 8 deletions

diff --git a/virtinst/xmlutil.py b/virtinst/xmlutil.py
index fb5a2856..7ef0ef03 100644
--- a/virtinst/xmlutil.py
+++ b/virtinst/xmlutil.py
@@ -8,6 +8,11 @@
 import os
 
 
+class DevError(RuntimeError):
+    def __init__(self, msg):
+        RuntimeError.__init__(self, "programming error: %s" % msg)
+
+
 def listify(l):
     if l is None:
         return []
@@ -61,13 +66,5 @@ def set_prop_path(obj, prop_path, value):
     return setattr(parent, pieces[-1], value)
 
 
-def raise_programming_error(cond, msg):
-    """
-    Small helper to raise a consistent error message for coding issues
-    """
-    if cond:
-        raise RuntimeError("programming error: %s" % msg)
-
-
 def in_testsuite():
     return "VIRTINST_TEST_SUITE" in os.environ