diff options
| author | Cole Robinson <crobinso@redhat.com> | 2022-02-20 11:40:35 -0500 |
|---|---|---|
| committer | Cole Robinson <crobinso@redhat.com> | 2022-02-20 11:40:35 -0500 |
| commit | 363fca413cae336a0ca86cbdcbb2f65fead948ee (patch) | |
| tree | 82b741f2ce1f198d18bac4cba37bb5378c83ae46 /virtinst/virtinstall.py | |
| parent | 5ebd4313f2c13bedfe02543089f110898f88ae7b (diff) | |
| download | virt-manager-363fca413cae336a0ca86cbdcbb2f65fead948ee.tar.gz | |
virt-install: Require --osinfo for non-x86 HVM case too
It's generally not as valuable for non-x86 where we don't have the
history of supporting non-virtio OSes, but as time goes on it will
likely become more relevant for non-x86 arches, so let's make this
change now to get ahead of it.
Signed-off-by: Cole Robinson <crobinso@redhat.com>
Diffstat (limited to 'virtinst/virtinstall.py')
| -rw-r--r-- | virtinst/virtinstall.py | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/virtinst/virtinstall.py b/virtinst/virtinstall.py index de1945b6..b0dc4891 100644 --- a/virtinst/virtinstall.py +++ b/virtinst/virtinstall.py @@ -355,9 +355,13 @@ def _show_memory_warnings(guest): def _needs_accurate_osinfo(guest): - # Limit it to hvm x86 guests which presently our defaults - # only really matter for - return guest.os.is_x86() and guest.os.is_hvm() + # HVM is really the only case where OS impacts what we set for defaults, + # so far. + # + # Historically we would only warn about missing osinfo on x86, but + # with the change to make osinfo mandatory we relaxed the arch check, + # so virt-install behavior is more consistent. + return guest.os.is_hvm() def show_guest_warnings(options, guest): |