storage: Check for pool name collisions against the pool cache

Rather than using storagePoolLookupByName. This will save some API
calls, but the main benefit is that it can help shake out cache
issues.

1 files changed, 8 insertions, 3 deletions

diff --git a/virtinst/storage.py b/virtinst/storage.py
index 8733d87d..c5f1f1a4 100644
--- a/virtinst/storage.py
+++ b/virtinst/storage.py
@@ -295,9 +295,14 @@ class StoragePool(_StorageObject):
         Finds a name similar (or equal) to passed 'basename' that is not
         in use by another pool. Extra params are passed to generate_name
         """
-        return util.generate_name(basename,
-                                  conn.storagePoolLookupByName,
-                                  **kwargs)
+        def cb(name):
+            for pool in conn.fetch_all_pools():
+                if pool.name == name:
+                    return True
+            return False
+
+        kwargs["lib_collision"] = False
+        return util.generate_name(basename, cb, **kwargs)
 
 
     def __init__(self, *args, **kwargs):