summaryrefslogtreecommitdiff
path: root/virtManager
diff options
context:
space:
mode:
authorCole Robinson <crobinso@redhat.com>2020-08-26 12:05:54 -0400
committerCole Robinson <crobinso@redhat.com>2020-08-26 16:01:30 -0400
commitb06d7c47f334a11d9d31a55c03f0083d06da09fb (patch)
tree97c3fff5dfe7fa7db651d8df2894a928898612c8 /virtManager
parent3425d514beac59497369202abac0dd34ae10198f (diff)
downloadvirt-manager-b06d7c47f334a11d9d31a55c03f0083d06da09fb.tar.gz
domain: Fake jobinfo support for the test driver
This let's us test more code, including behavior that's closer to standard QEMU driver behavior Signed-off-by: Cole Robinson <crobinso@redhat.com>
Diffstat (limited to 'virtManager')
-rw-r--r--virtManager/migrate.py2
-rw-r--r--virtManager/object/domain.py8
-rw-r--r--virtManager/vmmenu.py2
3 files changed, 7 insertions, 5 deletions
diff --git a/virtManager/migrate.py b/virtManager/migrate.py
index 0dea2c1b..ad864ecd 100644
--- a/virtManager/migrate.py
+++ b/virtManager/migrate.py
@@ -372,7 +372,7 @@ class vmmMigrateDialog(vmmGObjectUI):
self.set_finish_cursor()
cancel_cb = None
- if self.vm.getjobinfo_supported:
+ if self.vm.supports_domain_job_info():
cancel_cb = (self._cancel_migration, self.vm)
if uri:
diff --git a/virtManager/object/domain.py b/virtManager/object/domain.py
index 07c5a67a..6e1828a7 100644
--- a/virtManager/object/domain.py
+++ b/virtManager/object/domain.py
@@ -57,7 +57,7 @@ def start_job_progress_thread(vm, meter, progtext):
return True
- if vm.getjobinfo_supported:
+ if vm.supports_domain_job_info():
t = threading.Thread(target=jobinfo_cb,
name="job progress reporting",
args=())
@@ -371,9 +371,11 @@ class vmmDomain(vmmLibvirtObject):
# Support checks #
##################
- def _get_getjobinfo_supported(self):
+ def supports_domain_job_info(self):
+ if self.conn.is_test():
+ # jobinfo isn't actually supported but this tests more code
+ return True
return self.conn.support.domain_job_info(self._backend)
- getjobinfo_supported = property(_get_getjobinfo_supported)
def snapshots_supported(self):
if not self.conn.support.domain_list_snapshots(self._backend):
diff --git a/virtManager/vmmenu.py b/virtManager/vmmenu.py
index 5883ce34..5d953fb9 100644
--- a/virtManager/vmmenu.py
+++ b/virtManager/vmmenu.py
@@ -181,7 +181,7 @@ class VMActionUI(object):
return
_cancel_cb = None
- if vm.getjobinfo_supported:
+ if vm.supports_domain_job_info():
_cancel_cb = (VMActionUI.save_cancel, vm)
def cb(asyncjob):