summaryrefslogtreecommitdiff
path: root/virtManager/createvol.py
diff options
context:
space:
mode:
authorCole Robinson <crobinso@redhat.com>2019-06-16 21:12:39 -0400
committerCole Robinson <crobinso@redhat.com>2019-06-17 00:12:31 -0400
commitf107e399890830780b2ac3c8a06c30b9da1c1d97 (patch)
tree06260f80f989acbb9d8b81faf9ec393641656575 /virtManager/createvol.py
parent2c03ea5c9222955d1eba3fe3f308e55aa8c84461 (diff)
downloadvirt-manager-f107e399890830780b2ac3c8a06c30b9da1c1d97.tar.gz
Switch to more traditional logging structure
Init a shared log instance in virtinst/logger.py, and use that throughout the code base, so we aren't calling directly into 'logging'. This helps protect our logging output from being cluttered with other library output, as happens with some 'requests' usage
Diffstat (limited to 'virtManager/createvol.py')
-rw-r--r--virtManager/createvol.py17
1 files changed, 8 insertions, 9 deletions
diff --git a/virtManager/createvol.py b/virtManager/createvol.py
index 6aa0ef04..6751e4bb 100644
--- a/virtManager/createvol.py
+++ b/virtManager/createvol.py
@@ -4,11 +4,10 @@
# This work is licensed under the GNU GPLv2 or later.
# See the COPYING file in the top-level directory.
-import logging
-
from gi.repository import Gtk
from gi.repository import Gdk
+from virtinst import log
from virtinst import StorageVolume
from . import uiutil
@@ -61,17 +60,17 @@ class vmmCreateVolume(vmmGObjectUI):
try:
parent_xml = self._parent_pool.xmlobj.get_xml()
except Exception:
- logging.debug("Error getting parent_pool xml", exc_info=True)
+ log.debug("Error getting parent_pool xml", exc_info=True)
parent_xml = None
- logging.debug("Showing new volume wizard for parent_pool=\n%s",
+ log.debug("Showing new volume wizard for parent_pool=\n%s",
parent_xml)
self._reset_state()
self.topwin.set_transient_for(parent)
self.topwin.present()
def close(self, ignore1=None, ignore2=None):
- logging.debug("Closing new volume wizard")
+ log.debug("Closing new volume wizard")
self.topwin.hide()
if self._storage_browser:
self._storage_browser.close()
@@ -177,7 +176,7 @@ class vmmCreateVolume(vmmGObjectUI):
if ret and suffix:
ret = ret.rsplit(".", 1)[0]
except Exception:
- logging.exception("Error finding a default vol name")
+ log.exception("Error finding a default vol name")
return ret
@@ -254,7 +253,7 @@ class vmmCreateVolume(vmmGObjectUI):
def _build_xmlobj_from_xmleditor(self):
xml = self._xmleditor.get_xml()
- logging.debug("Using XML from xmleditor:\n%s", xml)
+ log.debug("Using XML from xmleditor:\n%s", xml)
return self._make_stub_vol(xml=xml)
def _build_xmlobj_from_ui(self):
@@ -336,9 +335,9 @@ class vmmCreateVolume(vmmGObjectUI):
vol.pool = newpool
meter = asyncjob.get_meter()
- logging.debug("Starting background vol creation.")
+ log.debug("Starting background vol creation.")
vol.install(meter=meter)
- logging.debug("vol creation complete.")
+ log.debug("vol creation complete.")
################