summaryrefslogtreecommitdiff
path: root/virt-xml
diff options
context:
space:
mode:
authorPavel Hrdina <phrdina@redhat.com>2019-12-03 13:02:21 +0100
committerPavel Hrdina <phrdina@redhat.com>2019-12-03 13:04:37 +0100
commit29f9f5f2d7f47fe6cc3333f2a9e6c6209db5a8f3 (patch)
tree0979b7fab83b56c40ee676198464299a47570f36 /virt-xml
parent5f0155508d4eed708f5ec06724e8ea6261d395e9 (diff)
downloadvirt-manager-29f9f5f2d7f47fe6cc3333f2a9e6c6209db5a8f3.tar.gz
virt-xml: fix defined_xml_is_unchanged
Commit <53f075ab76e1c372474ae0d88f202e487d9f213f> added a warning if the VM XML is not changed after removing default devices but the code was incorrect. We have to compare strings instead of string vs Guest object and also the condition was inverted. Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Diffstat (limited to 'virt-xml')
-rwxr-xr-xvirt-xml4
1 files changed, 2 insertions, 2 deletions
diff --git a/virt-xml b/virt-xml
index 71445c9f..7b0174c9 100755
--- a/virt-xml
+++ b/virt-xml
@@ -105,8 +105,8 @@ def get_domain_and_guest(conn, domstr):
def defined_xml_is_unchanged(conn, domain, original_xml):
rawxml = get_xmldesc(domain, inactive=True)
- new_xml = virtinst.Guest(conn, parsexml=rawxml)
- return new_xml != original_xml
+ new_xml = virtinst.Guest(conn, parsexml=rawxml).get_xml()
+ return new_xml == original_xml
################