diff options
| author | Cole Robinson <crobinso@redhat.com> | 2020-01-25 15:11:02 -0500 |
|---|---|---|
| committer | Cole Robinson <crobinso@redhat.com> | 2020-01-26 11:24:20 -0500 |
| commit | 0335c9ce62d7c9d716756e933d0ab9275a589616 (patch) | |
| tree | 7cb23263c3082c2a5a9a723b0435668b790b2098 /ui | |
| parent | b4b497e28f3f3e32a05f4cf78c21f07022ee824b (diff) | |
| download | virt-manager-0335c9ce62d7c9d716756e933d0ab9275a589616.tar.gz | |
virtManager: Remove maximum VCPUS API and VCPU hotplug
This was proposed here:
https://www.redhat.com/archives/virt-tools-list/2019-June/msg00117.html
"""
* UI maxmem and maxcpu notions, and related memballoon and cpu hotplug
operations. These have been in the UI forever but I'm not sure people
actually use them. cpu hotplug has always been a mess, and unless the
user plans ahead by setting a high maxmem value ballooning is only good
for reducing memory. These all sound like advanced usage to me that
just confuses the typical usecase of adding more mem or vcpus to an
offline VM. And the hotplug operations with virsh are simple to invoke.
So I'd like to drop this from the UI
"""
The remaining UI field now sets both maximum and current VCPU
allocation.
Signed-off-by: Cole Robinson <crobinso@redhat.com>
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/details.ui | 116 |
1 files changed, 42 insertions, 74 deletions
diff --git a/ui/details.ui b/ui/details.ui index 9b968944..c58d09f1 100644 --- a/ui/details.ui +++ b/ui/details.ui @@ -61,13 +61,6 @@ <property name="step_increment">1</property> <property name="page_increment">10</property> </object> - <object class="GtkAdjustment" id="adjustment6"> - <property name="lower">1</property> - <property name="upper">1024</property> - <property name="value">1</property> - <property name="step_increment">1</property> - <property name="page_increment">2</property> - </object> <object class="GtkAdjustment" id="adjustment7"> <property name="lower">1</property> <property name="upper">1024</property> @@ -1452,27 +1445,12 @@ </packing> </child> <child> - <object class="GtkLabel" id="label335"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="halign">start</property> - <property name="valign">center</property> - <property name="label" translatable="yes">Ma_ximum allocation:</property> - <property name="use_underline">True</property> - <property name="mnemonic_widget">cpu-maxvcpus</property> - </object> - <packing> - <property name="left_attach">0</property> - <property name="top_attach">2</property> - </packing> - </child> - <child> <object class="GtkLabel" id="label333"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">start</property> <property name="valign">center</property> - <property name="label" translatable="yes">Current a_llocation:</property> + <property name="label" translatable="yes">VCPU a_llocation:</property> <property name="use_underline">True</property> <property name="mnemonic_widget">cpu-vcpus</property> </object> @@ -1482,25 +1460,12 @@ </packing> </child> <child> - <object class="GtkSpinButton" id="cpu-maxvcpus"> - <property name="visible">True</property> - <property name="can_focus">True</property> - <property name="invisible_char">●</property> - <property name="text" translatable="yes">1</property> - <property name="adjustment">adjustment6</property> - <property name="value">1</property> - <signal name="changed" handler="on_cpu_maxvcpus_changed" swapped="no"/> - </object> - <packing> - <property name="left_attach">1</property> - <property name="top_attach">2</property> - </packing> - </child> - <child> <object class="GtkSpinButton" id="cpu-vcpus"> <property name="visible">True</property> <property name="can_focus">True</property> + <property name="halign">start</property> <property name="valign">center</property> + <property name="hexpand">True</property> <property name="invisible_char">●</property> <property name="text" translatable="yes">2</property> <property name="adjustment">adjustment7</property> @@ -1520,53 +1485,50 @@ <property name="top_attach">1</property> </packing> </child> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">True</property> - <property name="position">0</property> - </packing> - </child> - <child> - <object class="GtkBox" id="cpu-vcpus-warn-box"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="spacing">6</property> - <child> - <object class="GtkImage" id="image9"> - <property name="visible">True</property> - <property name="can_focus">False</property> - <property name="halign">start</property> - <property name="stock">gtk-dialog-warning</property> - </object> - <packing> - <property name="expand">False</property> - <property name="fill">False</property> - <property name="position">0</property> - </packing> - </child> <child> - <object class="GtkLabel" id="label28"> - <property name="width_request">300</property> + <object class="GtkBox" id="cpu-vcpus-warn-box"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">start</property> - <property name="label" translatable="yes"><small>Overcommitting vCPUs can hurt performance</small></property> - <property name="use_markup">True</property> - <property name="wrap">True</property> - <property name="max_width_chars">32</property> + <property name="spacing">6</property> + <child> + <object class="GtkImage" id="image9"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="halign">start</property> + <property name="stock">gtk-dialog-warning</property> + </object> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="position">0</property> + </packing> + </child> + <child> + <object class="GtkLabel"> + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="label" translatable="yes"><small>Overcommitting vCPUs can hurt performance</small></property> + <property name="use_markup">True</property> + </object> + <packing> + <property name="expand">True</property> + <property name="fill">True</property> + <property name="position">1</property> + </packing> + </child> </object> <packing> - <property name="expand">True</property> - <property name="fill">True</property> - <property name="position">1</property> + <property name="left_attach">0</property> + <property name="top_attach">2</property> + <property name="width">2</property> </packing> </child> </object> <packing> - <property name="expand">True</property> + <property name="expand">False</property> <property name="fill">True</property> - <property name="position">1</property> + <property name="position">0</property> </packing> </child> </object> @@ -3187,6 +3149,12 @@ <property name="top_attach">3</property> </packing> </child> + <child> + <placeholder/> + </child> + <child> + <placeholder/> + </child> </object> </child> <child type="label"> |