diff options
| author | WGH <wgh@torlan.ru> | 2021-03-21 20:44:04 +0300 |
|---|---|---|
| committer | Cole Robinson <crobinso@redhat.com> | 2021-04-06 18:30:08 -0400 |
| commit | fae3fecc1e01d973109f16a13afeb9f5c44359c8 (patch) | |
| tree | 9795cc181e13666602375500b0e15306587b7dd5 /data | |
| parent | d9b5090e061e9fad9738359a8b1f86f16eac45cf (diff) | |
| download | virt-manager-fae3fecc1e01d973109f16a13afeb9f5c44359c8.tar.gz | |
Improve Secret Service interoperability
The current implementation of Secret Service keyring client assumes that
the last component of an item path is integer, which is not true for some
Secret Service server implementations (e.g. KeePassXC). Besides,
the Secret Service API documents advises against recording object path
(not to mentioning parsing it in any way), recommending using lookup attributes
instead[1].
This commit fixes the code to behave in more interoperable way.
- The item path (called "keyid" in code) is no longer parsed and stored anywhere.
- The secret item is looked up in the Secret Service using hvuri and machine
uuid attributes.
- /console-password with (username, keyid) is removed from GSettings
storage. Instead, only username is stored in /console-username.
[1] https://specifications.freedesktop.org/secret-service/latest/ch03.html
Resolves: #237
Diffstat (limited to 'data')
| -rw-r--r-- | data/org.virt-manager.virt-manager.gschema.xml | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/data/org.virt-manager.virt-manager.gschema.xml b/data/org.virt-manager.virt-manager.gschema.xml index d4ed2973..dadbb5b7 100644 --- a/data/org.virt-manager.virt-manager.gschema.xml +++ b/data/org.virt-manager.virt-manager.gschema.xml @@ -14,10 +14,10 @@ <description>When to scale the VM graphical console. -1 = global default, 0 = never, 1 = only when in full screen mode, 2 = Always</description> </key> - <key name="console-password" type="(si)"> - <default>("", -1)</default> - <summary>Username and secrets ID for graphical password</summary> - <description>Username and secrets ID for graphical password</description> + <key name="console-username" type="s"> + <default>""</default> + <summary>Username for graphical password</summary> + <description>Username for graphical password</description> </key> <key name="resize-guest" type="i"> |