diff options
| author | Cole Robinson <crobinso@redhat.com> | 2020-08-21 16:11:40 -0400 |
|---|---|---|
| committer | Cole Robinson <crobinso@redhat.com> | 2020-08-26 15:20:05 -0400 |
| commit | 8f4341bee8d44d8fd495ed2ba685a1e2258ab3c3 (patch) | |
| tree | ac16aae06ca44088df4f9e7ea645f56275b14352 | |
| parent | 543ddba9f2fd54cff42838955e53283de9b0d218 (diff) | |
| download | virt-manager-8f4341bee8d44d8fd495ed2ba685a1e2258ab3c3.tar.gz | |
host: Move xmleditor init earlier
It can be triggered via callbacks which may fire early,
so initialize it first
Signed-off-by: Cole Robinson <crobinso@redhat.com>
| -rw-r--r-- | virtManager/hostnets.py | 20 | ||||
| -rw-r--r-- | virtManager/hoststorage.py | 20 |
2 files changed, 20 insertions, 20 deletions
diff --git a/virtManager/hostnets.py b/virtManager/hostnets.py index ae706039..3a6cd426 100644 --- a/virtManager/hostnets.py +++ b/virtManager/hostnets.py @@ -86,6 +86,16 @@ class vmmHostNets(vmmGObjectUI): def _init_ui(self): self.widget("network-pages").set_show_tabs(False) + self._xmleditor = vmmXMLEditor(self.builder, self.topwin, + self.widget("net-details-align"), + self.widget("net-details")) + self._xmleditor.connect("changed", + lambda s: self._enable_net_apply(EDIT_NET_XML)) + self._xmleditor.connect("xml-requested", + self._xmleditor_xml_requested_cb) + self._xmleditor.connect("xml-reset", + self._xmleditor_xml_reset_cb) + # [ unique, label, icon name, icon size, is_active ] netListModel = Gtk.ListStore(str, str, str, int, bool) self.widget("net-list").set_model(netListModel) @@ -107,16 +117,6 @@ class vmmHostNets(vmmGObjectUI): self.widget("net-list").append_column(netCol) netListModel.set_sort_column_id(1, Gtk.SortType.ASCENDING) - self._xmleditor = vmmXMLEditor(self.builder, self.topwin, - self.widget("net-details-align"), - self.widget("net-details")) - self._xmleditor.connect("changed", - lambda s: self._enable_net_apply(EDIT_NET_XML)) - self._xmleditor.connect("xml-requested", - self._xmleditor_xml_requested_cb) - self._xmleditor.connect("xml-reset", - self._xmleditor_xml_reset_cb) - ############## # Public API # diff --git a/virtManager/hoststorage.py b/virtManager/hoststorage.py index 53abf6a5..3b1fa726 100644 --- a/virtManager/hoststorage.py +++ b/virtManager/hoststorage.py @@ -159,6 +159,16 @@ class vmmHostStorage(vmmGObjectUI): def _init_ui(self): self.widget("storage-pages").set_show_tabs(False) + self._xmleditor = vmmXMLEditor(self.builder, self.topwin, + self.widget("pool-details-align"), + self.widget("pool-details")) + self._xmleditor.connect("changed", + lambda s: self._enable_pool_apply(EDIT_POOL_XML)) + self._xmleditor.connect("xml-requested", + self._xmleditor_xml_requested_cb) + self._xmleditor.connect("xml-reset", + self._xmleditor_xml_reset_cb) + # These are enabled in storagebrowser.py self.widget("browse-local").set_visible(False) self.widget("browse-cancel").set_visible(False) @@ -238,16 +248,6 @@ class vmmHostStorage(vmmGObjectUI): pool_list.get_selection().set_select_function( (lambda *x: self._confirm_changes()), None) - self._xmleditor = vmmXMLEditor(self.builder, self.topwin, - self.widget("pool-details-align"), - self.widget("pool-details")) - self._xmleditor.connect("changed", - lambda s: self._enable_pool_apply(EDIT_POOL_XML)) - self._xmleditor.connect("xml-requested", - self._xmleditor_xml_requested_cb) - self._xmleditor.connect("xml-reset", - self._xmleditor_xml_reset_cb) - ############### # Public APIs # |