| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Problem: Compiler warning for unused variable.
Solution: Move variable declaration. (John Marriott)
|
|
|
|
|
| |
Problem: Accuracy of profiling is not optimal.
Solution: Use CLOCK_MONOTONIC if possible. (Ernie Rael, closes #12129)
|
|
|
|
|
| |
Problem: Functions without arguments are not always declared properly.
Solution: Use "(void)" instead of "()". (Yegappan Lakshmanan, closes #12031)
|
|
|
|
|
|
| |
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11879)
|
|
|
|
|
|
| |
Problem: Callback name argument is changed by setqflist().
Solution: Use the expanded function name for the callback, do not store it
in the argument. (closes #11653)
|
|
|
|
|
|
| |
Problem: It is not easy to see what client-server commands are doing.
Solution: Add channel log messages if ch_log() is available. Move the
channel logging and make it available with the +eval feature.
|
|
|
|
|
| |
Problem: MS-Windows: warning for using int for size_t.
Solution: Declare variable as size_t.
|
|
|
|
|
|
|
| |
Problem: Use of strftime() is not safe.
Solution: Check the return value of strftime(). Use a larger buffer and
correctly pass the available space. (Dominique Pellé, closes
#11348)
|
|
|
|
|
|
| |
Problem: Crash when popup with deleted timer is closed. (Igbanam
Ogbuluijah)
Solution: Check the timer still exists. (closes #11301)
|
|
|
|
|
| |
Problem: No good reason to build without the float feature.
Solution: Remove configure check for float and "#ifdef FEAT_FLOAT".
|
|
|
|
|
|
| |
Problem: Error message for wrong argument type is not specific.
Solution: Include more information in the error. (Yegappan Lakshmanan,
closes #11037)
|
|
|
|
|
| |
Problem: Checks for Dictionary argument often give a vague error message.
Solution: Give a useful error message. (Yegappan Lakshmanan, closes #11009)
|
|
|
|
|
| |
Problem: When 'cmdheight' is zero some messages are not displayed.
Solution: Use a popup notification window.
|
|
|
|
|
| |
Problem: Too many type casts for dict_get functions.
Solution: Change the key argument from "char_u *" to "char *".
|
|
|
|
|
|
| |
Problem: Some callers of rettv_list_alloc() check for not OK. (Christ van
Willegen)
Solution: Use "==" instead of "!=" when checking the return value.
|
|
|
|
|
| |
Problem: Channel log does not show invoking a timer callback.
Solution: Add a ch_log() call.
|
|
|
|
|
| |
Problem: Verbose check with dict_find() to see if a key is present.
Solution: Add dict_has_key(). (Yegappan Lakshmanan, closes #10074)
|
|
|
|
|
|
| |
Problem: Possible crash when invoking timer callback fails.
Solution: Initialize the typval. Give an error for an empty callback.
(closes #9636)
|
|
|
|
|
| |
Problem: MS-Windows: Support for MSVC 2003 is not useful.
Solution: Remove the exceptions for MSVC 2003. (Ken Takata, closes #9616)
|
|
|
|
|
| |
Problem: Translating strftime() argument results in check error.
Solution: Add gettext comment.
|
|
|
|
|
| |
Problem: Timer triggered at the debug prompt may cause trouble.
Solution: Do not trigger any timer at the debug prompt. (closes #9481)
|
|
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
|
|
|
|
|
|
| |
Problem: timer_info() has the wrong repeat value in a timer callback.
Solution: Do not add one to the repeat value when in the callback.
(closes #9294)
|
|
|
|
|
|
|
| |
Problem: When editing the command line a FocusLost callback may cause the
screen to scroll up.
Solution: Do not redraw at the last line but at the same place where the
command line was before. (closes #9295)
|
|
|
|
|
| |
Problem: Vim9: function call aborted despite try/catch. (Naohiro Ono)
Solution: Ignore error caught by try/catch. (closes #8755)
|
|
|
|
|
|
| |
Problem: Vim9: runtime and compile time type checks are not the same.
Solution: Add more runtime type checks for builtin functions. (Yegappan
Lakshmanan, closes #8646)
|
|
|
|
|
|
| |
Problem: Vim9: argument types are not checked at compile time.
Solution: Add several more type checks. Fix type check for matchaddpos().
(Yegappan Lakshmanan, closes #8619)
|
|
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move error messages to errors.h and give them a clear name.
|
|
|
|
|
|
| |
Problem: Vim9: argument types are not checked at compile time.
Solution: Add several more type checks, also at runtime. (Yegappan
Lakshmanan, closes #8587)
|
|
|
|
|
| |
Problem: Vim9: argument types are not checked at compile time.
Solution: Add more type checks. (Yegappan Lakshmanan, closes #8560)
|
|
|
|
|
| |
Problem: Vim9: no error when reltime() has invalid arguments.
Solution: Add an error. (closes #8562)
|
|
|
|
|
| |
Problem: Computing array length is done in various ways.
Solution: Use ARRAY_LENGTH everywhere. (Ken Takata, closes #8305)
|
|
|
|
|
| |
Problem: MS-Windows: using enc_locale() for strftime() might not work.
Solution: Use wcsftime(). (Ken Takata, closes #8271)
|
|
|
|
|
|
| |
Problem: Vim9: occasional crash when using try/catch and a timer.
Solution: Save and restore "need_rethrow" when invoking a timer callback.
(closes #7708)
|
|
|
|
|
| |
Problem: Various comments can be improved.
Solution: Various comment adjustments.
|
|
|
|
|
| |
Problem: Vim9: cannot pass "true" to timer_paused().
Solution: Use tv_get_bool(). (closes #6891)
|
|
|
|
|
| |
Problem: Strptime() does not use DST.
Solution: Set the tm_isdst field to -1. (Tomáš Janoušek, closes #6230)
|
|
|
|
|
| |
Problem: Clearing a struct is verbose.
Solution: Define and use CLEAR_FIELD() and CLEAR_POINTER().
|
|
|
|
|
| |
Problem: Loops are repeated.
Solution: Use FOR_ALL_ macros. (Yegappan Lakshmanan, closes #5882)
|
|
Problem: Time and timer related code is spread out.
Solution: Move time and timer related code to a new file. (Yegappan
Lakshmanan, closes #5604)
|