summaryrefslogtreecommitdiff
path: root/vala/valasourcefile.vala
diff options
context:
space:
mode:
authorPrinceton Ferro <princetonferro@gmail.com>2020-04-11 03:32:54 -0400
committerRico Tzschichholz <ricotz@ubuntu.com>2020-04-11 10:59:04 +0200
commit2ad4a6e8a6c7bf6b2a9fd5d825ad639c420df489 (patch)
tree5da70c50e978b425cf1211cefa9604f62aa0af60 /vala/valasourcefile.vala
parent09e565a511f43e48737b0bfb881ccfb32cf0ab82 (diff)
downloadvala-2ad4a6e8a6c7bf6b2a9fd5d825ad639c420df489.tar.gz
vala: Don't use possibly uninitialized backing field of package_name
Don't check _package_name directly, which may be null at the time installed_version is accessed. This fixes a bug where Vala wouldn't generate errors when using symbols that are unavailable for a package version. Introduced by 7f0e90a5c34f437b7ab8f9197a9d42fc835b1a60 Fixes https://gitlab.gnome.org/GNOME/vala/issues/971
Diffstat (limited to 'vala/valasourcefile.vala')
-rw-r--r--vala/valasourcefile.vala2
1 files changed, 1 insertions, 1 deletions
diff --git a/vala/valasourcefile.vala b/vala/valasourcefile.vala
index 2e270a06c..ac9000f49 100644
--- a/vala/valasourcefile.vala
+++ b/vala/valasourcefile.vala
@@ -70,7 +70,7 @@ public class Vala.SourceFile {
_version_requested = true;
- if (_package_name != null) {
+ if (package_name != null) {
_installed_version = context.pkg_config_modversion (package_name);
}