codegen: Support non-virtual signals with default handler

Fixes https://gitlab.gnome.org/GNOME/vala/issues/1056

1 files changed, 3 insertions, 10 deletions

diff --git a/vala/valasignal.vala b/vala/valasignal.vala
index 392b31489..df7d76199 100644
--- a/vala/valasignal.vala
+++ b/vala/valasignal.vala
@@ -222,24 +222,17 @@ public class Vala.Signal : Symbol, Callable {
 			}
 		}
 
-		if (!is_virtual && body != null) {
-			error = true;
-			Report.error (source_reference, "Only virtual signals can have a default signal handler body");
-		}
-
-
-		if (is_virtual) {
+		if (body != null || (is_virtual && external_package)) {
 			default_handler = new Method (name, return_type, source_reference);
 
 			default_handler.owner = owner;
-			default_handler.access = access;
+			default_handler.access = (is_virtual ? access : SymbolAccessibility.PRIVATE);
 			default_handler.external = external;
 			default_handler.hides = hides;
-			default_handler.is_virtual = true;
+			default_handler.is_virtual = is_virtual;
 			default_handler.signal_reference = this;
 			default_handler.body = body;
 
-
 			foreach (Parameter param in parameters) {
 				default_handler.add_parameter (param);
 			}