summaryrefslogtreecommitdiff
path: root/tests/ts/mount/fstab-none
diff options
context:
space:
mode:
authorRuediger Meier <ruediger.meier@ga-group.nl>2015-04-21 10:41:01 +0200
committerRuediger Meier <ruediger.meier@ga-group.nl>2015-04-21 14:58:30 +0200
commitfffe5f7c72121c054645c60c0bb49f653bb7142e (patch)
treeffe8d9702ce1cc879d2a1d79ec08cc52e40d93f5 /tests/ts/mount/fstab-none
parentf1849be96a2f3baff3a7c3776be2d02af20bea81 (diff)
downloadutil-linux-fffe5f7c72121c054645c60c0bb49f653bb7142e.tar.gz
tests: never use -o pipefail
It was hard to find out that pipefail was the reason why our test-suite could have random failures for aribtrary tests, for example the ones which are using ts_device_has_uuid() or ts_mount(). Bash's pipefall option is evil! It may return error for such a simple line like this one $ echo -e "xxx\nyyy" | grep -q "xxx" because the left echo command will get SIGPIPE when grep exits after the first match. So the command line above could return an error eventhough it does exactly what we want. This patch removes any pipefail from our tests. The funny thing is that I couldn't find any case where we relied on this feature anyway. Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Diffstat (limited to 'tests/ts/mount/fstab-none')
-rwxr-xr-xtests/ts/mount/fstab-none2
1 files changed, 0 insertions, 2 deletions
diff --git a/tests/ts/mount/fstab-none b/tests/ts/mount/fstab-none
index 082afe905..b90008f00 100755
--- a/tests/ts/mount/fstab-none
+++ b/tests/ts/mount/fstab-none
@@ -12,8 +12,6 @@ ts_check_test_command "$TS_CMD_FINDMNT"
ts_skip_nonroot
-set -o pipefail
-
ts_fstab_add "none" "$TS_MOUNTPOINT" "tmpfs" "rw,nosuid,nodev,relatime"
mkdir -p $TS_MOUNTPOINT