diff options
author | Benjamin Berg <bberg@redhat.com> | 2022-03-24 16:08:16 +0100 |
---|---|---|
committer | Benjamin Berg <bberg@redhat.com> | 2022-03-24 17:02:27 +0100 |
commit | 9058d45685d1c7c08d52fb64c393fed9eeed542b (patch) | |
tree | 4edf5610042ef6a734b436ebf6513523646317d4 /dbus | |
parent | 1003d5c2a69e6c28dcf68adf10181b5180b5defa (diff) | |
download | upower-9058d45685d1c7c08d52fb64c393fed9eeed542b.tar.gz |
Remove Wakeups API
The API relied on /proc/timer_stats which has been removed from the
kernel in 2017. Since then, the API has been non-functional (yet
incorrectly reporting support because the support test was buggy).
Just remove it completely. The debian codesearch does not uncover any
API users. Also, I doubt that any new API (based on tracing scheduler
events as perf would do) would map well to what exists now. i.e. if
something like this is re-implemented in UPower or elsewhere, then the
API should likely look different.
And, realistically, if this does need root privileges (i.e. can't be
moved to use BPF programs or so on user units), then we can also create
a new small daemon that is launched on-demand just for that.
Diffstat (limited to 'dbus')
-rw-r--r-- | dbus/meson.build | 1 | ||||
-rw-r--r-- | dbus/org.freedesktop.UPower.Wakeups.xml | 131 |
2 files changed, 0 insertions, 132 deletions
diff --git a/dbus/meson.build b/dbus/meson.build index 7657d9e..5fbf251 100644 --- a/dbus/meson.build +++ b/dbus/meson.build @@ -3,7 +3,6 @@ upowerd_dbus_interfaces = [ [ 'daemon', 'org.freedesktop.UPower', 'Daemon' ], [ 'device', 'org.freedesktop.UPower.Device', 'Device' ], [ 'kbd-backlight', 'org.freedesktop.UPower.KbdBacklight', 'KbdBacklight' ], - [ 'wakeups', 'org.freedesktop.UPower.Wakeups', 'Wakeups' ], ] upowerd_dbus_headers = [] diff --git a/dbus/org.freedesktop.UPower.Wakeups.xml b/dbus/org.freedesktop.UPower.Wakeups.xml deleted file mode 100644 index 7faa126..0000000 --- a/dbus/org.freedesktop.UPower.Wakeups.xml +++ /dev/null @@ -1,131 +0,0 @@ -<!DOCTYPE node PUBLIC -"-//freedesktop//DTD D-BUS Object Introspection 1.0//EN" -"http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd" [ - <!ENTITY ERROR_GENERAL "org.freedesktop.UPower.GeneralError"> -]> -<node name="/" xmlns:doc="http://www.freedesktop.org/dbus/1.0/doc.dtd"> - <interface name="org.freedesktop.UPower.Wakeups"> - <doc:doc> - <doc:description> - <doc:para> - org.freedesktop.UPower.Wakeups is a DBus interface implemented - by UPower. - It allows applications to watch what applications and drivers are - causing the wakeups on the system. - </doc:para> - </doc:description> - </doc:doc> - - <property name="HasCapability" type="b" access="read"> - <doc:doc> - <doc:description> - <doc:para> - If the system has the ability to profile wakeups. - </doc:para> - </doc:description> - </doc:doc> - </property> - - <!-- ************************************************************ --> - <method name="GetTotal"> - <arg name="value" direction="out" type="u"> - <doc:doc> - <doc:summary> - The number of wakeups per second. - </doc:summary> - </doc:doc> - </arg> - <doc:doc> - <doc:description> - <doc:para> - Get the number of wakeups per second. - </doc:para> - </doc:description> - <doc:errors> - <doc:error name="&ERROR_GENERAL;">if an error occured while getting the latency</doc:error> - </doc:errors> - </doc:doc> - </method> - - <!-- ************************************************************ --> - <signal name="TotalChanged"> - <arg name="value" direction="out" type="u"> - <doc:doc> - <doc:summary> - The number of wakeups per second. - </doc:summary> - </doc:doc> - </arg> - <doc:doc> - <doc:description> - <doc:para> - The number of wakeups per second has changed. - </doc:para> - </doc:description> - </doc:doc> - </signal> - - <!-- ************************************************************ --> - <method name="GetData"> - <arg name="data" direction="out" type="a(budss)"> - <doc:doc> - <doc:summary> - The data of all the processes and drivers which contribute to the - wakeups on the system. - <doc:list> - <doc:item> - <doc:term>is_userspace</doc:term> - <doc:definition> - If the wakeup is from userspace. - </doc:definition> - </doc:item> - <doc:item> - <doc:term>id</doc:term> - <doc:definition> - The process ID of the application, or the IRQ for kernel drivers. - </doc:definition> - </doc:item> - <doc:item> - <doc:term>value</doc:term> - <doc:definition> - The number of wakeups per second. - </doc:definition> - </doc:item> - <doc:item> - <doc:term>cmdline</doc:term> - <doc:definition> - The command line for the application, or NULL for kernel drivers. - </doc:definition> - </doc:item> - <doc:item> - <doc:term>details</doc:term> - <doc:definition> - The details about the wakeup. - </doc:definition> - </doc:item> - </doc:list> - </doc:summary></doc:doc> - </arg> - <doc:doc> - <doc:description> - <doc:para> - Gets all the wakeups from drivers and applications. - </doc:para> - </doc:description> - </doc:doc> - </method> - - <!-- ************************************************************ --> - <signal name="DataChanged"> - <doc:doc> - <doc:description> - <doc:para> - The wakeup data has changed. - </doc:para> - </doc:description> - </doc:doc> - </signal> - - </interface> - -</node> |