summaryrefslogtreecommitdiff
path: root/cmd/console.c
diff options
context:
space:
mode:
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>2023-01-28 01:11:56 +0100
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>2023-02-10 13:05:39 +0100
commitfe34e163e0a6b77894c5d533fbfe6909a8bccfb3 (patch)
treea20ca1e55ad86041f2b70a0050b5179f4e92d970 /cmd/console.c
parenteeb55254dd0808f008f9ce99195f61520daae28d (diff)
downloadu-boot-fe34e163e0a6b77894c5d533fbfe6909a8bccfb3.tar.gz
cmd: improve coninfo output formatting
Device name are typically longer than 8 characters. This leads to ragged output. Only the I and O bit of the device flags are of interest for the user. Writing a hexadecimal number is just confusing. Before the patch the output looked like this: => coninfo List of available devices: pl011@9000000 00000007 IO stdin stdout stderr serial 00000003 IO usbkbd 00000001 I. With the patch the output looks like this: => coninfo List of available devices |-- pl011@9000000 (IO) | |-- stdin | |-- stdout | |-- stderr |-- serial (IO) |-- usbkbd (I) Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'cmd/console.c')
-rw-r--r--cmd/console.c14
1 files changed, 6 insertions, 8 deletions
diff --git a/cmd/console.c b/cmd/console.c
index 9a1db83c7c..620a961cde 100644
--- a/cmd/console.c
+++ b/cmd/console.c
@@ -22,23 +22,21 @@ static int do_coninfo(struct cmd_tbl *cmd, int flag, int argc,
/* Scan for valid output and input devices */
- puts ("List of available devices:\n");
+ puts("List of available devices\n");
list_for_each(pos, list) {
dev = list_entry(pos, struct stdio_dev, list);
- printf ("%-8s %08x %c%c ",
- dev->name,
- dev->flags,
- (dev->flags & DEV_FLAGS_INPUT) ? 'I' : '.',
- (dev->flags & DEV_FLAGS_OUTPUT) ? 'O' : '.');
+ printf("|-- %s (%s%s)\n",
+ dev->name,
+ (dev->flags & DEV_FLAGS_INPUT) ? "I" : "",
+ (dev->flags & DEV_FLAGS_OUTPUT) ? "O" : "");
for (l = 0; l < MAX_FILES; l++) {
if (stdio_devices[l] == dev) {
- printf ("%s ", stdio_names[l]);
+ printf("| |-- %s\n", stdio_names[l]);
}
}
- putc ('\n');
}
return 0;
}