diff options
| author | Heinrich Schuchardt <xypron.glpk@gmx.de> | 2021-08-17 07:11:58 +0200 |
|---|---|---|
| committer | Stefan Roese <sr@denx.de> | 2021-09-01 08:09:24 +0200 |
| commit | f0317d788221828089fe54433cf5c502d748ef77 (patch) | |
| tree | eac96cac9cd154b1dc2e284c445ebe3d2cd94c75 | |
| parent | f858bb2e6c191da3981838937950cb3c98e488fe (diff) | |
| download | u-boot-f0317d788221828089fe54433cf5c502d748ef77.tar.gz | |
kwbimage: check return value of image_get_csk_index
image_get_csk_index() may return -1 in case of an error. Don't use this
value as index.
This resolves Coverity CID 338488
Memory - illegal accesses (NEGATIVE_RETURNS)
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Pali Rohár <pali@kernel.org>
| -rw-r--r-- | tools/kwbimage.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/kwbimage.c b/tools/kwbimage.c index b2694888d9..aa865cc443 100644 --- a/tools/kwbimage.c +++ b/tools/kwbimage.c @@ -1087,7 +1087,7 @@ int kwb_sign_csk_with_kak(struct image_tool_params *params, int csk_idx = image_get_csk_index(); struct sig_v1 tmp_sig; - if (csk_idx >= 16) { + if (csk_idx < 0 || csk_idx > 15) { fprintf(stderr, "Invalid CSK index %d\n", csk_idx); return 1; } |