diff options
| author | Heinrich Schuchardt <xypron.glpk@gmx.de> | 2019-08-22 21:58:26 +0200 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2019-08-30 14:17:11 -0400 |
| commit | 3c7166dbb464a65d9822cfee7c233a7d8c1a9672 (patch) | |
| tree | 5bda38829d6f2310bf224eff1f36740e62797210 | |
| parent | 40a13173b5d461bd43184dc1478d3a0f5becf55f (diff) | |
| download | u-boot-3c7166dbb464a65d9822cfee7c233a7d8c1a9672.tar.gz | |
siemens: avoid out of bound access
char num[1];
sprintf(num, "%d", i);
leads to a buffer overrun.
Simplify the overly complex coding.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Heiko Schocher <hs@denx.de>
| -rw-r--r-- | board/siemens/common/board.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/board/siemens/common/board.c b/board/siemens/common/board.c index 676935a843..75462d1c34 100644 --- a/board/siemens/common/board.c +++ b/board/siemens/common/board.c @@ -189,14 +189,11 @@ void set_env_gpios(unsigned char state) { char *ptr_env; char str_tmp[5]; /* must contain "ledX"*/ - char num[1]; unsigned char i, idx, pos1, pos2, ccount; unsigned char gpio_n, gpio_s0, gpio_s1; for (i = 0; i < MAX_NR_LEDS; i++) { - strcpy(str_tmp, "led"); - sprintf(num, "%d", i); - strcat(str_tmp, num); + sprintf(str_tmp, "led%d", i); /* If env var is not found we stop */ ptr_env = env_get(str_tmp); |