diff options
author | Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> | 2020-06-09 13:07:38 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-06-09 21:07:38 +0100 |
commit | cfbb905034c928f073639af00b30d74951744b61 (patch) | |
tree | 39e689e4941568f5b05892fcfbba02c0573eddeb /CHANGES.md | |
parent | e382275bad2bd11fb5df33dd7db520fd7596f4ac (diff) | |
download | thrift-cfbb905034c928f073639af00b30d74951744b61.tar.gz |
THRIFT-5214: Reset read deadline in socketConn
Client: go
This is a slightly different, and less error-prone approach from the
fix in e382275b.
The previous approach relies on passing the set socket timeout into the
underlying socketConn from TSocket and TSSLSocket. But since we have so
many different constructors for TSocket and TSSLSocket, some makes the
initial connection in the constructor and some does not, there are so
many different places we would need to remember to pass socketTimeout
into socketConn. In the future, when we add another constructor to them,
we could either forget to pass the socket timeout into socketConn, or
try to pass it while we haven't constructed socketConn yet (which will
cause panic), both are bad.
In this approach we just clear the read deadline in the connectivity
check read. Because that's a non-blocking read, it would work just fine
without a read deadline.
Diffstat (limited to 'CHANGES.md')
0 files changed, 0 insertions, 0 deletions